Skip to content

Bug bashing fixes for qasm support #2393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 14, 2025
Merged

Bug bashing fixes for qasm support #2393

merged 3 commits into from
May 14, 2025

Conversation

idavis
Copy link
Collaborator

@idavis idavis commented May 12, 2025 •
edited
Loading

Fixes:

  • Qubits must be declared globally.
  • No longer using file ext for type, language id is passed into LS
  • Cleaning up debugger
  • Adding missing awaits in TS
  • QIR profile errors now show in openqasm docs
  • Clearing command errors should work again.

Fixes #2366
Fixes #2368
Fixes #2379
Fixes #2391
Fixes #2392

@idavis idavis self-assigned this May 12, 2025
@idavis idavis marked this pull request as draft May 12, 2025 22:53
@idavis idavis force-pushed the iadavis/qasm-support-fixes branch from c6c5d68 to 3a3bfbb Compare May 13, 2025 11:50
@idavis idavis marked this pull request as ready for review May 13, 2025 12:23
@idavis idavis force-pushed the iadavis/qasm-support-fixes branch 2 times, most recently from f0d2223 to 76956d4 Compare May 13, 2025 21:50
@idavis idavis force-pushed the iadavis/qasm-support-fixes branch from 76956d4 to 44d8a83 Compare May 13, 2025 21:53
@idavis idavis changed the title BB Fixes for qasm Bug bashing fixes for qasm support May 13, 2025
DmitryVasilevsky
DmitryVasilevsky approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@DmitryVasilevsky DmitryVasilevsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving qubit declaration in a non-global scope part.

swernli
swernli reviewed May 13, 2025
View reviewed changes
swernli
swernli reviewed May 13, 2025
View reviewed changes
swernli
swernli reviewed May 13, 2025
View reviewed changes
swernli
swernli reviewed May 13, 2025
View reviewed changes
swernli
swernli approved these changes May 13, 2025
View reviewed changes
Copy link
Collaborator

@swernli swernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off on all but the typescript

billti
billti reviewed May 14, 2025
View reviewed changes
@idavis idavis enabled auto-merge May 14, 2025 16:19
@idavis idavis added this pull request to the merge queue May 14, 2025
Merged via the queue into main with commit e67f768 May 14, 2025
18 checks passed
@idavis idavis deleted the iadavis/qasm-support-fixes branch May 14, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billti billti billti approved these changes

@swernli swernli swernli approved these changes

@minestarks minestarks minestarks approved these changes

@DmitryVasilevsky DmitryVasilevsky DmitryVasilevsky approved these changes

@ScottCarda-MS ScottCarda-MS Awaiting requested review from ScottCarda-MS

Assignees

@idavis idavis

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@idavis @billti @swernli @minestarks @DmitryVasilevsky