Skip to content

Circuit Code Improvements #2329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 24, 2025
Merged

Circuit Code Improvements #2329

merged 6 commits into from
Apr 24, 2025

Conversation

ScottCarda-MS
Copy link
Contributor

@ScottCarda-MS ScottCarda-MS commented Apr 23, 2025 •
edited
Loading

  • Remove lodash dependency
  • Rename Metadata in npm to a GateRenderData
  • Encapsulate the circuit-editor CSS classes under the circuit-panel class
  • Use num_qubits instead of max_q_id

@ScottCarda-MS ScottCarda-MS marked this pull request as ready for review April 23, 2025 19:14
@ScottCarda-MS ScottCarda-MS mentioned this pull request Apr 21, 2025
Open
21 tasks
minestarks
minestarks approved these changes Apr 23, 2025
View reviewed changes
@ScottCarda-MS ScottCarda-MS added the circuit-editor Issues related to the circuit-editor label Apr 23, 2025
@ScottCarda-MS ScottCarda-MS added this pull request to the merge queue Apr 24, 2025
Merged via the queue into main with commit 1693b25 Apr 24, 2025
18 checks passed
@ScottCarda-MS ScottCarda-MS deleted the sccarda/CodeImprovements branch April 24, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swernli swernli swernli approved these changes

@minestarks minestarks minestarks approved these changes

@billti billti Awaiting requested review from billti billti is a code owner

@DmitryVasilevsky DmitryVasilevsky Awaiting requested review from DmitryVasilevsky

@idavis idavis Awaiting requested review from idavis idavis is a code owner

Assignees
No one assigned
Labels
circuit-editor Issues related to the circuit-editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ScottCarda-MS @swernli @minestarks