Skip to content

Conversation

billti
Copy link
Member

@billti billti commented Apr 22, 2025

Circuit rendering now appears as per the below in VS Code (and have tested in JupyterLabs in both Safari and Edge browsers, and in light and dark themes).

image

Copy link
Contributor

@ScottCarda-MS ScottCarda-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a couple of questions. It'd be nice to make use of that mathChars table you added to ensure consistency with the characters.

@ScottCarda-MS
Copy link
Contributor

Also, there is a regex here that checks against a variety of possible bar and bracket character use. It looks like you added a new bar character that wasn't captured before. Could you add it to the regex?

@ScottCarda-MS ScottCarda-MS mentioned this pull request Apr 21, 2025
21 tasks
@billti billti enabled auto-merge April 24, 2025 18:58
@billti billti added this pull request to the merge queue Apr 24, 2025
Merged via the queue into main with commit 30fe6a6 Apr 24, 2025
18 checks passed
@billti billti deleted the billti/circuit-font branch April 24, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants