Broadcasting and slicing updates #2326

orpuente-MS · 2025-04-22T21:51:33Z

This PR completes some postponed items from #2149 related to broadcasting, indexing, and arrays:

Gate call broadcasting.
Array declaration.
Multidimensional array indexing.
Multidimensional array assignment.
Array slicing.
Bitarray const evaluation.
Fixes issue with assign ops being compiled incorrectly.

compiler/qsc_qasm/src/compiler.rs

compiler/qsc_qasm/src/parser/stmt.rs

compiler/qsc_qasm/src/semantic/lowerer.rs

compiler/qsc_qasm/src/semantic/types.rs

compiler/qsc_qasm/src/compiler.rs

compiler/qsc_qasm/src/semantic/lowerer.rs

compiler/qsc_qasm/src/tests/statement/gate_call.rs

compiler/qsc_qasm/src/semantic/lowerer.rs

Co-authored-by: Stefan J. Wernli <[email protected]>

compiler/qsc_qasm/src/semantic/types.rs

swernli

Good stuff!

Co-authored-by: Stefan J. Wernli <[email protected]>

orpuente-MS added 7 commits April 21, 2025 16:44

broadcasting

c190235

fix parsing and lowering of indexed idents

12f8fae

update indexed_ident tests

8a04ec0

broadcasting edge case

14293f5

update unit tests

a80a5a6

remove empty lines

4a8f3ff

unignore slicing tests

c2596b4

idavis changed the title ~~Qasm parser follow up~~ Broadcasting and slicing updates Apr 22, 2025

orpuente-MS added 2 commits April 22, 2025 15:21

box IdentOrIndexedIdent

d3ca004

allow broadcast with mixed registers and qubits

f549de4

idavis reviewed Apr 22, 2025

View reviewed changes

compiler/qsc_qasm/src/compiler.rs Show resolved Hide resolved

idavis reviewed Apr 22, 2025

View reviewed changes

compiler/qsc_qasm/src/parser/stmt.rs Show resolved Hide resolved

idavis reviewed Apr 22, 2025

View reviewed changes

compiler/qsc_qasm/src/semantic/lowerer.rs Outdated Show resolved Hide resolved

idavis reviewed Apr 22, 2025

View reviewed changes

compiler/qsc_qasm/src/semantic/lowerer.rs Outdated Show resolved Hide resolved

idavis reviewed Apr 22, 2025

View reviewed changes

compiler/qsc_qasm/src/semantic/lowerer.rs Outdated Show resolved Hide resolved

idavis reviewed Apr 22, 2025

View reviewed changes

compiler/qsc_qasm/src/semantic/lowerer.rs Outdated Show resolved Hide resolved

idavis reviewed Apr 22, 2025

View reviewed changes

compiler/qsc_qasm/src/semantic/lowerer.rs Show resolved Hide resolved

orpuente-MS and others added 3 commits April 24, 2025 08:21

array indexing (work in progress)

4c46ea9

zero range step error

5c8fa54

Merge branch 'main' into oscarpuente/qasm-follow-up

32ba718

orpuente-MS marked this pull request as ready for review April 24, 2025 21:23

orpuente-MS requested review from minestarks and swernli as code owners April 24, 2025 21:23

idavis marked this pull request as draft April 29, 2025 18:07

orpuente-MS and others added 6 commits April 30, 2025 09:08

arrays support

5f92556

Merge branch 'main' into oscarpuente/qasm-follow-up

464b977

update unit tests after merge

f6b7a77

add indexed assign tests

267acbd

multidimensional indexed assign

2395efd

use w/= for first index of multidimensional assignment

81f8cbd

idavis reviewed May 2, 2025

View reviewed changes

compiler/qsc_qasm/src/semantic/types.rs Outdated Show resolved Hide resolved

idavis reviewed May 2, 2025

View reviewed changes

compiler/qsc_qasm/src/semantic/types.rs Show resolved Hide resolved

idavis reviewed May 2, 2025

View reviewed changes

compiler/qsc_qasm/src/compiler.rs Outdated Show resolved Hide resolved

idavis reviewed May 2, 2025

View reviewed changes

compiler/qsc_qasm/src/semantic/lowerer.rs Show resolved Hide resolved

orpuente-MS added 6 commits May 2, 2025 13:02

address PR feedback in semantic/types.rs

91a5c9e

remove comented out code

583cb47

add zero size array and subarrays tests

b447d38

lift 3-dimensions array restriction in crate::types.rs

8ae812f

fix typo

07d8f40

improve array unit tests

93b660e

idavis marked this pull request as ready for review May 2, 2025 21:27

idavis self-requested a review May 2, 2025 21:28

idavis approved these changes May 2, 2025

View reviewed changes

swernli reviewed May 5, 2025

View reviewed changes

compiler/qsc_qasm/src/tests/statement/gate_call.rs Show resolved Hide resolved

add test case for broadcast of double controlled gate

f3f9f63

swernli reviewed May 6, 2025

View reviewed changes

compiler/qsc_qasm/src/semantic/lowerer.rs Outdated Show resolved Hide resolved

rename check_lit_array_type to check_lit_array_size

2cada40

swernli reviewed May 6, 2025

View reviewed changes

compiler/qsc_qasm/src/semantic/lowerer.rs Outdated Show resolved Hide resolved

swernli reviewed May 6, 2025

View reviewed changes

compiler/qsc_qasm/src/semantic/lowerer.rs Outdated Show resolved Hide resolved

Update compiler/qsc_qasm/src/semantic/lowerer.rs

856c460

Co-authored-by: Stefan J. Wernli <[email protected]>

swernli reviewed May 6, 2025

View reviewed changes

compiler/qsc_qasm/src/semantic/types.rs Outdated Show resolved Hide resolved

swernli approved these changes May 6, 2025

View reviewed changes

orpuente-MS and others added 3 commits May 6, 2025 13:38

Update compiler/qsc_qasm/src/semantic/types.rs

ce63b72

Co-authored-by: Stefan J. Wernli <[email protected]>

cargo fmt types.rs

88f4905

cleanup index_into_qubit_register impl

17ff72f

orpuente-MS enabled auto-merge May 6, 2025 21:15

orpuente-MS added this pull request to the merge queue May 6, 2025

Merged via the queue into main with commit d53d48f May 6, 2025
18 checks passed

orpuente-MS deleted the oscarpuente/qasm-follow-up branch May 6, 2025 21:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Broadcasting and slicing updates #2326

Broadcasting and slicing updates #2326

Uh oh!

orpuente-MS commented Apr 22, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

swernli left a comment

Uh oh!

Uh oh!

Uh oh!

Broadcasting and slicing updates #2326

Broadcasting and slicing updates #2326

Uh oh!

Conversation

orpuente-MS commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

swernli left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

orpuente-MS commented Apr 22, 2025 •

edited

Loading