Skip to content

Added RoundHalfAwayFromZero to standard library #2321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2025
Merged

Added RoundHalfAwayFromZero to standard library #2321

merged 2 commits into from
Apr 21, 2025

Conversation

DmitryVasilevsky
Copy link
Contributor

@DmitryVasilevsky DmitryVasilevsky commented Apr 21, 2025 •
edited
Loading

  • Added RoundHalfAwayFromZero to standard library.
  • Simplified Round (which is actually rounding half towards zero)
  • Updated comments and added reference to Wikipedia
  • Added tests
  • Changed QasmStd to use this new function instead of separate implementation

@DmitryVasilevsky DmitryVasilevsky requested a review from idavis April 21, 2025 21:42
@github-actions GitHub Actions
Copy link

Change in memory usage detected by benchmark.

Memory Report for 201a96a

Test This Branch On Main Difference
compile core + standard lib 19849189 bytes 19840641 bytes 8548 bytes

@github-actions GitHub Actions
Copy link

Change in memory usage detected by benchmark.

Memory Report for fa369d6

Test This Branch On Main Difference
compile core + standard lib 19849189 bytes 19840641 bytes 8548 bytes

ScottCarda-MS
ScottCarda-MS reviewed Apr 21, 2025
View reviewed changes
@idavis idavis enabled auto-merge April 21, 2025 23:04
@idavis idavis added this pull request to the merge queue Apr 21, 2025
Merged via the queue into main with commit 90961b2 Apr 21, 2025
18 checks passed
@idavis idavis deleted the dmitryv/std-rounding branch April 21, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScottCarda-MS ScottCarda-MS ScottCarda-MS approved these changes

@idavis idavis idavis approved these changes

@swernli swernli swernli approved these changes

@minestarks minestarks Awaiting requested review from minestarks minestarks is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DmitryVasilevsky @idavis @swernli @ScottCarda-MS