Skip to content

Fix widgets sometimes rendering in light theme when VS Code is in a dark theme #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Fix widgets sometimes rendering in light theme when VS Code is in a dark theme #2120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions npm/qsharp/ux/qsharp-ux.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,11 +501,6 @@ html {

/* Space chart */

/* Needed until https://github.com/microsoft/vscode-jupyter/issues/7161 is resolved */
.cell-output-ipywidget-background {
background-color: transparent !important;
}

#pieChart {
fill: var(--main-color);
}
Expand Down
16 changes: 16 additions & 0 deletions widgets/js/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,22 @@ type RenderArgs = {
export function render({ model, el }: RenderArgs) {
const componentType = model.get("comp");

// There is an existing issue where in VS Code it always shows the widget background as white.
// (See https://github.com/microsoft/vscode-jupyter/issues/7161)
// We tried to fix this in CSS by overridding the style, but there is a race condition whereby
// depending on which style gets injected first (ours or ipywidgets), it may or may not work.

// The solution here is to force our own override to be last in the style list if not already.
// It's a bit of a hack, but it works, and I couldn't find something better that wouldn't be fragile.

if (
!el.ownerDocument.head.lastChild?.textContent?.includes("widget-css-fix")
) {
const forceStyle = el.ownerDocument.createElement("style");
forceStyle.textContent = `/* widget-css-fix */ .cell-output-ipywidget-background {background-color: transparent !important;}`;
el.ownerDocument.head.appendChild(forceStyle);
}

switch (componentType) {
case "SpaceChart":
renderChart({ model, el });
Expand Down
Loading