Skip to content

Deprecate set Keyword #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Dec 16, 2024
Merged

Deprecate set Keyword #2062

merged 12 commits into from
Dec 16, 2024

Conversation

ScottCarda-MS
Copy link
Contributor

@ScottCarda-MS ScottCarda-MS commented Dec 12, 2024 •
edited
Loading

Makes the set keyword optional for assignment expressions. Adds a lint and code action to deprecate the use of the set keyword. The lint level is set to "Allow".

Closes #1496

@ScottCarda-MS ScottCarda-MS marked this pull request as ready for review December 13, 2024 18:21
swernli
swernli reviewed Dec 13, 2024
View reviewed changes
swernli
swernli reviewed Dec 13, 2024
View reviewed changes
swernli
swernli approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@swernli swernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor comments on the lint portion, but otherwise quite happy with how this turned out!

@sezna sezna mentioned this pull request Dec 14, 2024
Open
9 tasks
swernli
swernli approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@swernli swernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at the new lint, phrasing is consistent and should be helpful to folks!

orpuente-MS
orpuente-MS reviewed Dec 16, 2024
View reviewed changes
@ScottCarda-MS ScottCarda-MS added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit 8fefdd5 Dec 16, 2024
18 checks passed
@ScottCarda-MS ScottCarda-MS deleted the sccarda/RemoveSet branch December 16, 2024 22:18
@filipw filipw mentioned this pull request Mar 17, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 18, 2025
@filipw @minestarks
Removed usage of deprecated set keyword from the samples (#2233)
e0df7cc 
The language samples still stated:

> // Mutable variables can be mutated with the `set` keyword

Technically this is true, but since `set` is now
[deprecated](#2062) I removed it
from all the samples.

---------

Co-authored-by: Mine Starks <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swernli swernli swernli approved these changes

@orpuente-MS orpuente-MS orpuente-MS approved these changes

@DmitryVasilevsky DmitryVasilevsky Awaiting requested review from DmitryVasilevsky DmitryVasilevsky is a code owner

@sezna sezna Awaiting requested review from sezna

@tcNickolas tcNickolas Awaiting requested review from tcNickolas

@idavis idavis Awaiting requested review from idavis idavis is a code owner

@minestarks minestarks Awaiting requested review from minestarks minestarks is a code owner

@billti billti Awaiting requested review from billti billti is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make set keyword optional and include lint to suggest avoiding it.
3 participants
@ScottCarda-MS @swernli @orpuente-MS