Add BaseCollector #324
Merged
Add BaseCollector #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhupr
force-pushed
the
add_base_collector
branch
from
cf5bee3 to
6f18778
Compare
you-n-g
reviewed
Mar 10, 2021
scripts/data_collector/base.py
Outdated
| self.save_stock(symbol, df) | ||
| return _result | ||
|
|
||
| def save_stock(self, symbol, df: pd.DataFrame): |
There was a problem hiding this comment.
rename stock to instrument will make it sound more general
scripts/data_collector/base.py
Outdated
|
|
||
| def collector_data(self): | ||
| """collector data""" | ||
| logger.info("start collector yahoo data......") |
zhupr
force-pushed
the
add_base_collector
branch
from
6f18778 to
cef1c30
Compare
zhupr
force-pushed
the
add_base_collector
branch
from
cef1c30 to
42be8ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.pyunder upper directory ofqlib.Screenshots of Test Results (if appropriate):
Types of changes