[BUG] Firefox browser.close throws `Protocol error (Browser.removeBrowserContext): Browser closed`

[mxschmitt]

Context:

• Playwright Version: 1.10, 1.9, ...
• Operating System: Mac, Linux
• Node.js version: 14
• Browser: Firefox
• Original issue: Firefox fails intermittently for test playwright-community/jest-playwright#661

Code Snippet

Minimal reproducible:

const playwright = require("playwright");

// 1. Install code-server `npm install code-server` and run locally: `npx code-server`
// 2. node test.js

(async () => {
  const browserServer = await playwright.firefox.launchServer()
  const browser = await playwright.firefox.connect({
    wsEndpoint: browserServer.wsEndpoint()
  })
  const context = await browser.newContext();
  const page = await context.newPage()

  await page.goto("http://localhost:8080")
  const title = await page.title()
  console.log({ title })
  try {
    await browser.close()
  } catch(err) {
    console.log("yes here: ↓")
    console.log(err)
  }
  await browserServer.close()
})()

This throws at the browser.close() statement around 5 of 10 times the following:

browser.close: Protocol error (Browser.removeBrowserContext): Browser closed.
==================== Browser output: ====================
<launching> /Users/temporaryadmin/Library/Caches/ms-playwright/firefox-1238/firefox/Nightly.app/Contents/MacOS/firefox -no-remote -headless -profile /var/folders/q8/c1b5lsw56474bw7wrmy0wqw80000gp/T/playwright_firefoxdev_profile-sSHRZ9 -juggler-pipe -silent
<launched> pid=50412
[pid=50412][err] *** You are running in headless mode.
[pid=50412][out] 
[pid=50412][out] Juggler listening to the pipe
[pid=50412][out] console.warn: SearchSettings: "get: No settings file exists, new profile?" (new Error("", "(unknown module)"))
[pid=50412][out] Crash Annotation GraphicsCriticalError: |[C0][GFX1-]: Receive IPC close with reason=AbnormalShutdown (t=0.808932) [GFX1-]: Receive IPC close with reason=AbnormalShutdown
[pid=50412][err] Exiting due to channel error.
[pid=50412][out] Crash Annotation GraphicsCriticalError: |[C0][GFX1-]: Receive IPC close with reason=AbnormalShutdown (t=1.14308) [GFX1-]: Receive IPC close with reason=AbnormalShutdown
[pid=50412][err] Exiting due to channel error.
Error
    at Object.captureStackTrace (/Users/temporaryadmin/development/jest-playwright-repro/node_modules/playwright/lib/utils/stackTrace.js:48:19)
    at Connection.sendMessageToServer (/Users/temporaryadmin/development/jest-playwright-repro/node_modules/playwright/lib/client/connection.js:69:48)
    at Proxy.<anonymous> (/Users/temporaryadmin/development/jest-playwright-repro/node_modules/playwright/lib/client/channelOwner.js:64:61)
    at /Users/temporaryadmin/development/jest-playwright-repro/node_modules/playwright/lib/client/browser.js:69:31
    at FirefoxBrowser._wrapApiCall (/Users/temporaryadmin/development/jest-playwright-repro/node_modules/playwright/lib/client/channelOwner.js:77:34)
    at FirefoxBrowser.close (/Users/temporaryadmin/development/jest-playwright-repro/node_modules/playwright/lib/client/browser.js:68:24)
    at /Users/temporaryadmin/development/jest-playwright-repro/test.js:18:19

[Tallyb]

Any chance something similar happens on macos chromium: downgrading to 1.9.2 solves it.

 page.waitForSelector: Protocol error (DOM.describeNode): Browser closed.
       ==================== Browser output: ====================
       <launching> /Users/me/Library/Caches/ms-playwright/chromium-857950/chrome-mac/Chromium.app/Contents/MacOS/Chromium --disable-background-networking --enable-features=NetworkService,NetworkServiceInProcess --disable-background-timer-throttling --disable-backgrounding-occluded-windows --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-background-pages --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=TranslateUI,BlinkGenPropertyTrees,ImprovedCookieControls,SameSiteByDefaultCookies,LazyFrameLoading --disable-hang-monitor --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost --disable-renderer-backgrounding --disable-sync --force-color-profile=srgb --metrics-recording-only --no-first-run --enable-automation --password-store=basic --use-mock-keychain --user-data-dir=/var/folders/99/y2bb165n66q99tqwsv7bpt600000gn/T/playwright_chromiumdev_profile-vT6xKj --remote-debugging-pipe --headless --hide-scrollbars --mute-audio --blink-settings=primaryHoverType=2,availableHoverTypes=2,primaryPointerType=4,availablePointerTypes=4 --no-sandbox --use-fake-ui-for-media-stream --use-fake-device-for-media-stream --no-startup-window
       <launched> pid=92589
       [pid=92589][err] Received signal 11 SEGV_MAPERR 000000000008
       [pid=92589][err]  [0x00011571dce9]
       [pid=92589][err]  [0x0001156730d3]
       [pid=92589][err]  [0x00011571db11]
       [pid=92589][err]  [0x7fff20668d7d]
       [pid=92589][err]  [0x000000000000]
       [pid=92589][err]  [0x000113b39920]
       [pid=92589][err]  [0x000113b395ca]
       [pid=92589][err]  [0x000113b324ea]
       [pid=92589][err]  [0x000113b32100]
       [pid=92589][err]  [0x000113b31fe7]
       [pid=92589][err]  [0x0001156d7ec8]
       [pid=92589][err]  [0x0001156eb351]
       [pid=92589][err]  [0x0001156eb02a]
       [pid=92589][err]  [0x0001157312b7]
       [pid=92589][err]  [0x00011572b5e2]
       [pid=92589][err]  [0x000115730cef]
       [pid=92589][err]  [0x7fff2071ca0c]
       [pid=92589][err]  [0x7fff2071c974]
       [pid=92589][err]  [0x7fff2071c6ef]
       [pid=92589][err]  [0x7fff2071b121]
       [pid=92589][err]  [0x7fff2071a6ce]
       [pid=92589][err]  [0x7fff214a7fa1]
       [pid=92589][err]  [0x000115731801]
       [pid=92589][err]  [0x00011573089c]
       [pid=92589][err]  [0x0001156eb99b]
       [pid=92589][err]  [0x0001156b61fb]
       [pid=92589][err]  [0x0001157081b8]
       [pid=92589][err]  [0x00011570837b]
       [pid=92589][err]  [0x000115727be8]
       [pid=92589][err]  [0x7fff20624950]
       [pid=92589][err]  [0x7fff2062047b]
       [pid=92589][err] [end of stack trace]

[mxschmitt]

@Tallyb is it reproducible? Yours sounds more like a Chromium crash and is by that a different issue.

[Tallyb]

@mxschmitt - it is consistent. happened on 2 separate machines (both macs). should I open a separate issue?

[mxschmitt]

@Tallyb yeah would be awesome!

[pavelfeldman]

This is still very important, but is not a regression. Looks like this happens if the browser is closed immediately after opening.

[aslushnikov]

@mxschmitt Interestingly, I cannot reproduce this on playwright@next - looks like firefox roll has fixed this. Can you please confirm?

[jsjoeio]

Using playwright@next, I couldn't reproduce either. I ran it 10 times as well and 10/10 showed expected results.

Video

Screen.Recording.2021-04-05.at.12.09.42.PM.mov

[mxschmitt]

@aslushnikov I can verify that I can't repro on tip-of-tree anymore, seems fixed upstream. Tested 20 times and all worked well.