Onboard jaz to Microsoft's OpenJDK container images #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3r3kk
reviewed
Nov 5, 2025
| # Redeclare ARG to make it available in this build stage | ||
| ARG INSTALLER_TAG | ||
| ARG JDK_VERSION | ||
| ARG JDK_URL="https://aka.ms/download-jdk/microsoft-jdk-${JDK_VERSION}-linux-ARCH.tar.gz" |
Contributor
There was a problem hiding this comment.
Is this a variable or something? (Perhaps a nicety of dockerfiles?)
Suggested change
| ARG JDK_URL="https://aka.ms/download-jdk/microsoft-jdk-${JDK_VERSION}-linux-ARCH.tar.gz" | |
| ARG JDK_URL="https://aka.ms/download-jdk/microsoft-jdk-${JDK_VERSION}-linux-$ARCH.tar.gz" |
Contributor
There was a problem hiding this comment.
Noup, it is a word that gets replaced with the proper architecture. It is good as it is.
Luigi96
reviewed
Nov 6, 2025
scripts/validate-image.sh
Outdated
| if [[ "$jaz_version_string" =~ "jaz version:" ]]; then | ||
| echo "::notice title=JAZ present ($jdkversion-$distro)::Image '${image}' has JAZ installed." | ||
| else | ||
| echo "::warning title=JAZ missing ($jdkversion-$distro)::Image '${image}' does not have JAZ installed." |
Contributor
There was a problem hiding this comment.
Do we want to just have a warning or should it fail? We will add jaz to all of our images correct?
Contributor
Author
There was a problem hiding this comment.
Yeah, I think that is what we want (to fail).
Contributor
|
You have some warnings and issues for JDK25 |
Contributor
Author
Jaz team pushed a new version, and this is now resolved. |
jmjaffe37
reviewed
Nov 7, 2025
Contributor
jmjaffe37
left a comment
jmjaffe37
left a comment
There was a problem hiding this comment.
Looks good to me. I am ready to approve when all remaining comments are addressed :)
Luigi96
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will add the
jazpackage to Microsoft's OpenJDK container images. In addition to adding the new package, there are additional smoke tests which were added to verify thejazinstallation.validate-image.sh, we now check to determine that a version ofjazis installed. If we are able to validate specific versions, then we can introduce that logic into this change. Though for now, ideally, we want to ensure thatjazis included with the images.2. Enables execution thetest-image.shscript in CI. This script will create containers which will run simple java programs. One of the containers will run invokingjazand ensures that any argumentsjazgenerates as defaults are accepted byjava.Note: Some files were using CRLF line endings those were changed to use LF endings.