-
Notifications
You must be signed in to change notification settings - Fork 98
[torchlib] Fix and implement overloads for aten::remainder #2727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Justin Chu <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2727 +/- ##
==========================================
- Coverage 70.07% 70.07% -0.01%
==========================================
Files 226 226
Lines 27266 27276 +10
Branches 2754 2754
==========================================
+ Hits 19107 19113 +6
- Misses 7209 7213 +4
Partials 950 950 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes the aten::remainder.Scalar_Tensor overload which previously failed because it attempted to access the dtype attribute on a scalar value. The fix separates the three overload variants into distinct functions, ensuring that dtype is always obtained from a tensor operand.
- Split the combined decorator for
.Tensorand.Scalaroverloads into separate implementations - Added dedicated implementation for
.Scalaroverload (Tensor, float) - Added dedicated implementation for
.Scalar_Tensoroverload (float, Tensor)
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Previously the Scalar_Tensor overload will fail because the first arg will be a scalar which does not have dtype.