Skip to content

Conversation

@gramalingam
Copy link
Collaborator

Introduce basic infrastructure for merging metadata props (for use in rewriter/optimizer etc.) A basic version added to rewriter.

TODO:

  • Allow user control over this: should this be configurable at the level of a RewriteRuleSet? Or, perhaps at a global level (given that ORT fusions uses a number of rewrite-rule-sets for various reasons)?
  • This line should also be factored out or made user-controllable in some fashion. Otherwise, the metadata gets lost anyway.

Signed-off-by: Ganesan Ramalingam <[email protected]>
Signed-off-by: Ganesan Ramalingam <[email protected]>
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 81.81818% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.12%. Comparing base (93783ee) to head (9ffcdb6).
⚠️ Report is 29 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
onnxscript/utils/metadata_merger.py 82.05% 5 Missing and 2 partials ⚠️
onnxscript/rewriter/_rewrite_rule.py 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2682      +/-   ##
==========================================
- Coverage   70.46%   70.12%   -0.34%     
==========================================
  Files         224      225       +1     
  Lines       26812    27000     +188     
  Branches     2686     2711      +25     
==========================================
+ Hits        18893    18935      +42     
- Misses       6987     7131     +144     
- Partials      932      934       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can have a test?

@github-project-automation github-project-automation bot moved this from Todo to Done in ONNX Script Review Board Nov 5, 2025
@gramalingam gramalingam merged commit 971f9bb into main Nov 5, 2025
33 checks passed
@gramalingam gramalingam deleted the rama/rrmeta2 branch November 5, 2025 19:11
@titaiwangms titaiwangms self-requested a review November 6, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

3 participants