Enhanced type annotations and simplified implementation of scatter.value #2612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

justinchuby merged 2 commits into microsoft:main from linshokaku:follow-2605

Oct 7, 2025

+10 −10

Contributor

linshokaku commented Oct 7, 2025 •

edited by justinchuby

Loading

follow #2605


          Enhanced type annotations and simplified implementation of scatter.value

7e9af5b

Signed-off-by: Linsho Kaku <[email protected]>

github-project-automation bot added this to ONNX Script Review Board

github-project-automation bot moved this to Todo in ONNX Script Review Board

justinchuby added the module: torchlib label

justinchuby reviewed

View reviewed changes

onnxscript/function_libs/torch_lib/ops/core.py Outdated Show resolved Hide resolved

justinchuby reviewed

View reviewed changes

onnxscript/function_libs/torch_lib/ops/core.py Outdated Show resolved Hide resolved

justinchuby reviewed

View reviewed changes

onnxscript/function_libs/torch_lib/ops/core.py Outdated Show resolved Hide resolved

justinchuby reviewed

View reviewed changes

onnxscript/function_libs/torch_lib/ops/core.py Outdated Show resolved Hide resolved

justinchuby reviewed

View reviewed changes

onnxscript/function_libs/torch_lib/ops/core.py Outdated Show resolved Hide resolved

justinchuby reviewed

View reviewed changes

onnxscript/function_libs/torch_lib/ops/core.py Outdated Show resolved Hide resolved

justinchuby reviewed

View reviewed changes

onnxscript/function_libs/torch_lib/ops/core.py Show resolved Hide resolved


          update type annotation

342ae14

Signed-off-by: Linsho Kaku <[email protected]>

linshokaku requested a review from justinchuby

October 7, 2025 02:45

justinchuby approved these changes

View reviewed changes

Collaborator

justinchuby left a comment

Thank you!

github-project-automation bot moved this from Todo to Done in ONNX Script Review Board

codecov bot commented Oct 7, 2025 •

edited

Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.95%. Comparing base (aa2cf4a) to head (342ae14).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2612   +/-   ##
=======================================
  Coverage   69.95%   69.95%           
=======================================
  Files         222      222           
  Lines       26311    26311           
  Branches     2604     2604           
=======================================
  Hits        18406    18406           
  Misses       6993     6993           
  Partials      912      912

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

justinchuby merged commit 6718ef0 into microsoft:main

32 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: torchlib