Skip to content

Conversation

@justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Aug 29, 2025

Organize all rules into a directory that is not with the rewriter infrastructure:

  • onnxscript.rewriter.rules.common.* for existing rules
  • onnxscript.rewriter.rules.fusion.* for onnx fusion rules

Organize all rules into a directory that is not with the rewriter infrastructure

Signed-off-by: Justin Chu <[email protected]>
@codecov
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

❌ Patch coverage is 99.23077% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 69.91%. Comparing base (2cc2502) to head (715f975).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...xscript/rewriter/rules/common/_basic_rules_test.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2531      +/-   ##
==========================================
- Coverage   70.00%   69.91%   -0.09%     
==========================================
  Files         215      216       +1     
  Lines       25988    26049      +61     
  Branches     2606     2614       +8     
==========================================
+ Hits        18192    18213      +21     
- Misses       6896     6936      +40     
  Partials      900      900              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Justin Chu <[email protected]>
@gramalingam
Copy link
Collaborator

Thanks for doing this, have been thinking about doing this for a while!

One question: do we need a separate folder, or should this be together with onnx_fusions? There is a clear distinction between ort_fusions and onnx_fusions: but for rules/optimizations that apply to standard onnx, what would the distinction between onnx_fusions and rules be?

Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
@justinchuby
Copy link
Collaborator Author

@gramalingam updated PR description and commits. For now I didn't touch ort_fusions. For onnx fusions, I organized the rules into rules/fusion.

Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
@justinchuby
Copy link
Collaborator Author

@gramalingam PTAL

@github-project-automation github-project-automation bot moved this from Todo to Done in ONNX Script Review Board Sep 3, 2025
@justinchuby justinchuby merged commit 54de741 into main Sep 3, 2025
32 checks passed
@justinchuby justinchuby deleted the justinchu/rewrite-api branch September 3, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

3 participants