-
Notifications
You must be signed in to change notification settings - Fork 98
Refactor rewrite rules into the rewriter.rules namespace #2531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Organize all rules into a directory that is not with the rewriter infrastructure Signed-off-by: Justin Chu <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2531 +/- ##
==========================================
- Coverage 70.00% 69.91% -0.09%
==========================================
Files 215 216 +1
Lines 25988 26049 +61
Branches 2606 2614 +8
==========================================
+ Hits 18192 18213 +21
- Misses 6896 6936 +40
Partials 900 900 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Justin Chu <[email protected]>
|
Thanks for doing this, have been thinking about doing this for a while! One question: do we need a separate folder, or should this be together with onnx_fusions? There is a clear distinction between ort_fusions and onnx_fusions: but for rules/optimizations that apply to standard onnx, what would the distinction between onnx_fusions and rules be? |
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
|
@gramalingam updated PR description and commits. For now I didn't touch ort_fusions. For onnx fusions, I organized the rules into rules/fusion. |
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
|
@gramalingam PTAL |
Organize all rules into a directory that is not with the rewriter infrastructure:
onnxscript.rewriter.rules.common.*for existing rulesonnxscript.rewriter.rules.fusion.*for onnx fusion rules