Skip to content

Minor fix for getting function's graph #2504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gramalingam merged 2 commits into from
Aug 22, 2025
Merged

Minor fix for getting function's graph #2504

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0d7d54
Minor fix for getting function's graph
gramalingam Aug 21, 2025
1217792
Fix attribute access for graph in _matcher.py
gramalingam Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions onnxscript/rewriter/_matcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,14 +183,14 @@ def _match_value(
self, pattern_value: _pattern_ir.ValuePattern, value: ir.Value | None
) -> bool:
"""Match an IR value against a ValuePattern instance."""
if value is not None and value.graph is not self._graph_or_function:
if value is not None and value.graph is not self._graph:
if not isinstance(
pattern_value, (_pattern_ir.Var, _pattern_ir.Constant, _pattern_ir.AnyValue)
):
# If the pattern value is a Var, Constant, or AnyValue, we allow it to match
# values from other graphs. Otherwise, we fail the match.
return self.fail(
f"Value {value.name} is not in the graph {self._graph_or_function.name}. "
f"Value {value.name} is not in the graph {self._graph.name}. "
Copy link
Collaborator

@justinchuby justinchuby Aug 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the graph name is not currently set as the function name. So this will show None.

f"Pattern matches crossing graph boundaries are not supported."
)
if isinstance(pattern_value, _pattern_ir.AnyValue):
Expand Down Expand Up @@ -362,7 +362,10 @@ def match(
complications which require careful consideration.
"""
self._tracer = tracer
self._graph_or_function = graph_or_function[0].graph
if isinstance(graph_or_function, ir.Graph):
self._graph: ir.Graph = graph_or_function
else:
self._graph = graph_or_function.graph
if self.pattern.has_single_output_node:
self._init_match(verbose)
return self._match_single_output_node(
Expand Down
Loading