Do not run auditwheel on QNN whls #26837
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgchen1
reviewed
Dec 19, 2025
| + migraphx_dependencies | ||
| + tensorrt_dependencies | ||
| + cann_dependencies | ||
| + qnn_dependencies |
Contributor
There was a problem hiding this comment.
given that the only usage of qnn_dependencies is within this if branch, and now it won't run when is_qnn is true, do we still need qnn_dependencies?
| if is_manylinux and not disable_auditwheel_repair and not is_openvino: | ||
| # qnn links libc++ rather than libstdc++ for it's x86_64 dependencies which we currently do not | ||
| # support for many_linux. | ||
| if is_manylinux and not disable_auditwheel_repair and not is_openvino and not is_qnn: |
Contributor
There was a problem hiding this comment.
Is it possible to gate this on x86_64? QNN for ARM64 does link against libstdc++ so it's possible to target manylinux_2_34.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change 26634 added the qnn variant to the audit wheel process, but the qnn libraries do not pass audit repair due to a dependency on libc++. Continue to not audit qnn and rely on the correct dependencies being available for the user.
Motivation and Context
Fixes build packaging pipeline