Fixed bulk copy for batch inserting null datetime type data when sendTemporalDataTypesAsStringForBulkCopy=false #2702
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where inserting null temporal data types (datetime, smalldatetime) would fail when using bulk copy API (useBulkCopyForBatchInsert=true) with sendTemporalDataTypesAsStringForBulkCopy=false.
Background
Extended bulk copy for batch insert support for temporal and money datatypes #2670 - added bulk copy for batch insert support for temporal and money data types.
When sendTemporalDataTypesAsStringForBulkCopy connection property set to true (default), temporal types are sent as varchar strings to work around bulk copy limitations. When set to false, temporal types are sent as their native types.
However, the implementation missed proper null handling when sendTemporalDataTypesAsStringForBulkCopy=false, causing the following error:
Test Coverage
Added comprehensive test cases:
testBulkInsertWithNullDataForAllTemporalTypesAndMoney() - validates null handling when sendTemporalDataTypesAsStringForBulkCopy=false
testBulkInsertWithNullDataForAllTemporalTypesAndMoneyAsVarchar() - validates null handling when sendTemporalDataTypesAsStringForBulkCopy=true (default)