-
Notifications
You must be signed in to change notification settings - Fork 40
OBO flow changes using user managed identity credentials #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Code Quality Report✅ isort checks passed✅ Black checks passed✅ Flake8 checks passed❌ MyPy checks failed
✅ Pytest checks passed |
Code Quality Report✅ isort checks passed✅ Black checks passed✅ Flake8 checks passed✅ MyPy checks passed✅ Pytest checks passed |
fabric_rti_mcp/config/obo_config.py
Outdated
class OBOFlowEnvVarNames: | ||
"""Environment variable names for OBO Flow configuration.""" | ||
|
||
azure_tenant_id = "AZURE_TENANT_ID" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we prefix everything here with FABRIC_RTI_MCP_
(and also change the class name to FabricRtiMcpAuthConfig
or something more specific?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
fabric_rti_mcp/common.py
Outdated
|
||
|
||
DEFAULT_FABRIC_API_BASE = "https://api.fabric.microsoft.com/v1" | ||
DEFAULT_FABRIC_RTI_TRANSPORT = "stdio" | ||
DEFAULT_FABRIC_RTI_HTTP_PORT = 3000 | ||
DEFAULT_FABRIC_RTI_HTTP_PATH = "/mcp" | ||
DEFAULT_FABRIC_RTI_HTTP_HOST = "127.0.0.1" | ||
DEFAULT_FABRIC_RTI_STATELESS_HTTP = False | ||
DEFAULT_FABRIC_RTI_STATELESS_HTTP = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still should be false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my bad, changed for test. fixed :)
Code Quality Report✅ isort checks passed✅ Black checks passed✅ Flake8 checks passed✅ MyPy checks passed✅ Pytest checks passed |
No description provided.