Skip to content

Conversation

prvavill
Copy link
Contributor

@prvavill prvavill commented Sep 6, 2025

No description provided.

Copy link

github-actions bot commented Sep 6, 2025

Code Quality Report

✅ isort checks passed

✅ Black checks passed

✅ Flake8 checks passed

❌ MyPy checks failed

fabric_rti_mcp/authentication/token_obo_exchanger.py:5: error: Skipping analyzing "msal": module is installed, but missing library stubs or py.typed marker  [import-untyped]
fabric_rti_mcp/authentication/token_obo_exchanger.py:5: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Found 1 error in 1 file (checked 16 source files)

✅ Pytest checks passed

@prvavill prvavill marked this pull request as ready for review September 6, 2025 00:15
Copy link

github-actions bot commented Sep 6, 2025

Code Quality Report

✅ isort checks passed

✅ Black checks passed

✅ Flake8 checks passed

✅ MyPy checks passed

✅ Pytest checks passed

danield137
danield137 previously approved these changes Sep 6, 2025
class OBOFlowEnvVarNames:
"""Environment variable names for OBO Flow configuration."""

azure_tenant_id = "AZURE_TENANT_ID"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we prefix everything here with FABRIC_RTI_MCP_ (and also change the class name to FabricRtiMcpAuthConfig or something more specific?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done



DEFAULT_FABRIC_API_BASE = "https://api.fabric.microsoft.com/v1"
DEFAULT_FABRIC_RTI_TRANSPORT = "stdio"
DEFAULT_FABRIC_RTI_HTTP_PORT = 3000
DEFAULT_FABRIC_RTI_HTTP_PATH = "/mcp"
DEFAULT_FABRIC_RTI_HTTP_HOST = "127.0.0.1"
DEFAULT_FABRIC_RTI_STATELESS_HTTP = False
DEFAULT_FABRIC_RTI_STATELESS_HTTP = True
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still should be false

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, changed for test. fixed :)

Copy link

github-actions bot commented Sep 8, 2025

Code Quality Report

✅ isort checks passed

✅ Black checks passed

✅ Flake8 checks passed

✅ MyPy checks passed

✅ Pytest checks passed

@prvavill prvavill merged commit fdab2d1 into main Sep 8, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants