Skip to content

Conversation

radennis
Copy link

Create data activator tool that sends an alert on teams based on an eventhouse query.

@@ -0,0 +1,3 @@
"""
Fabric Data Activator module for the Fabric RTI MCP server.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no top level comments

Returns:
Dictionary containing the created alert details
"""
sys.stderr.write(f"=== ACTIVATOR SERVICE: create_kql_alert called ===\n")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the logging framework from common code

:param description: Optional description for the alert
:return: List containing the alert creation result
"""
import sys
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

top evel imports only

import sys
# Try writing to a debug file as well as stderr
try:
with open("c:/temp/fabric_debug.log", "a") as f:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we cannot write to local files without consent

return [{"error": str(e), "status": "failed"}]


async def list_fabric_workspaces() -> List[Dict[str, Any]]:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to common code please?

from azure.identity import DefaultAzureCredential


class FabricConnection:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

common code. the whole auth part is common across services

logger.error(f"Platform: {sys.platform}")
# print pid
logger.error(f"PID: {os.getpid()}")
print(f"DEBUG: About to create FastMCP server", flush=True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove these

@@ -0,0 +1,160 @@
# Data Activator MCP Tools Guide
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

who is this for? llm or humans?

@@ -0,0 +1,262 @@
# Data Activator Implementation Guide
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm...don't think we want this in the repo

@@ -0,0 +1,130 @@
#!/usr/bin/env python3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm adding live test config in #65 . probably can leverage it to test the mcp directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants