Skip to content

[Medium] Patch kubevirt for CVE-2024-33394 #14315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Medium] Patch kubevirt for CVE-2024-33394 #14315

wants to merge 3 commits into from

Conversation

BinduSri-6522866
Copy link
Contributor

@BinduSri-6522866 BinduSri-6522866 commented Jul 16, 2025 •
edited
Loading

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

Patch kubevirt for CVE-2024-33394
Patch Modified: Yes

  • Patch was backported for manifests/generated/operator-csv.yaml.in and manifests/generated/rbac-operator.authorization.k8s.yaml.in due to version mismatch between existing "kubevirt" and "Astrolabe Patch".
  • Astrolabe Patch Reference: kubevirt/kubevirt@772bb22
Change Log
  • new: SPECS/kubevirt/CVE-2024-33394
  • modified: SPECS/kubevirt/kubevirt.spec
Does this affect the toolchain?

NO

Links to CVEs
Test Methodology
  • Local build
  • Patch applies cleanly
image

@BinduSri-6522866 BinduSri-6522866 requested a review from a team as a code owner July 16, 2025 15:20
@BinduSri-6522866 BinduSri-6522866 marked this pull request as draft July 16, 2025 15:21
@BinduSri-6522866 BinduSri-6522866 marked this pull request as ready for review July 17, 2025 03:54
@Malateshk007 Malateshk007 requested a review from mfrw July 17, 2025 06:21
mfrw
mfrw reviewed Jul 28, 2025
View reviewed changes
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triggered Test Build.
Reviewing patch meanwhile.

SPECS/kubevirt/kubevirt.spec
@@ -225,6 +226,9 @@ install -p -m 0644 cmd/virt-handler/nsswitch.conf %{buildroot}%{_datadir}/kube-v
%{_bindir}/virt-tests

%changelog
* Fri Jul 11 2025 BinduSri Adabala <[email protected]> - 0.59.0-29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Build Triggered: link

mfrw
mfrw approved these changes Jul 29, 2025
View reviewed changes
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Malateshk007
Copy link

@LeoMar4 / @0xba1a / @kgodara912 , gentle reminder for review and approval!

mfrw
mfrw approved these changes Aug 8, 2025
View reviewed changes
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-Off By: Muhammad Falak.

LGTM - the changes are ok to be merged.

@0xba1a
Copy link
Contributor

0xba1a commented Aug 11, 2025

@LeoMar4 / @0xba1a / @kgodara912 , gentle reminder for review and approval!

@Malateshk007 Please wait for FTE signoff before seeking stable-maintainer approval.

0xba1a
0xba1a reviewed Aug 11, 2025
View reviewed changes
SPECS/kubevirt/kubevirt.spec Outdated
@@ -45,6 +45,7 @@ Patch12: CVE-2025-22869.patch
Patch13: CVE-2023-48795.patch
Patch14: CVE-2024-51744.patch
Patch15: CVE-2025-22872.patch
Patch16: CVE-2024-33394.patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use spaces instead of tab

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed.

0xba1a
0xba1a requested changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@0xba1a 0xba1a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor whitespace change required.

@Malateshk007
Copy link

@LeoMar4 / @0xba1a / @kgodara912 , gentle reminder for review and approval!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xba1a 0xba1a 0xba1a requested changes

@mfrw mfrw mfrw approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
main PR Destined for main Packaging security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BinduSri-6522866 @Malateshk007 @0xba1a @mfrw @Kanishk-Bansal