fix(core): support CRLF line endings in extract_json_from_str codeblock regex - #8081
Open
Xayar145 wants to merge 2 commits into
Open
fix(core): support CRLF line endings in extract_json_from_str codeblock regex#8081Xayar145 wants to merge 2 commits into
Xayar145 wants to merge 2 commits into
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supports CRLF (
\r\n) line endings inautogen_core.utils.extract_json_from_str:r"```(?:\s*([\w\+\-]+))?\r?\n([\s\S]*?)```"to match code blocks formatted with Windows/network CRLF line endings.test_extract_json_from_str_crlfintest_json_extraction.py.Motivation
When JSON code blocks are received over network streams or generated on Windows environments with CRLF line endings, the previous regex pattern required strict LF (
\n), causing extraction to fail and falling back to unparsed strings.Changes
python/packages/autogen-core/src/autogen_core/utils/_load_json.py: Match optional\rin codeblock regex.python/packages/autogen-core/tests/test_json_extraction.py: Added test case with CRLF line endings.Tests
test_extract_json_from_str_crlf.