fix: ignore injected LangChain tool parameters - #8061
Open
mikemikimike wants to merge 1 commit into
Open
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Closes #6385.
LangChainToolAdapterinfers a Pydantic input model from_runwhen a LangChain tool does not provideargs_schema. LangChain injectsrun_managerandcallbacksinto these signatures, but those internal parameters must not be exposed as tool inputs. Including them can make Pydantic schema generation fail for types such asCallbackManagerForToolRun.What changed?
run_managerandcallbacksparameters during fallback signature inference.args_schemaand verify only user-facing inputs are included.Compatibility
This only affects fallback schema inference for tools without
args_schema; tools with an explicit schema are unchanged. No public API changes.Checks
uv run --package autogen-ext --extra langchain --dev pytest packages/autogen-ext/tests/tools/test_langchain_tools.py -q— passed (2 tests).uv run --package autogen-ext --dev ruff check packages/autogen-ext/src/autogen_ext/tools/langchain/_langchain_adapter.py packages/autogen-ext/tests/tools/test_langchain_tools.py— passed.uv run --package autogen-ext --dev ruff format --check packages/autogen-ext/src/autogen_ext/tools/langchain/_langchain_adapter.py packages/autogen-ext/tests/tools/test_langchain_tools.py— passed.