fix: preserve TextMentionTermination sources in config#7837
Draft
maxpetrusenkoagent wants to merge 1 commit into
Draft
fix: preserve TextMentionTermination sources in config#7837maxpetrusenkoagent wants to merge 1 commit into
maxpetrusenkoagent wants to merge 1 commit into
Conversation
Contributor
|
@maxpetrusenkoagent please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TextMentionTerminationsourceswhen dumping/loading component configs.sourcesoptional and omitted when unset.Why
Issue #7487 asks for a mission-keeper style goal-integrity node. A practical building block already exists: a read-only integrity agent can emit a drift marker, and
TextMentionTerminationcan restrict that marker to the mission keeper source.Before this fix, saving/loading the termination condition dropped
sources, so any participant could trigger the marker after config round-trip.Addresses #7487.
Verification
.venv-agentchat/bin/python -m pytest packages/autogen-agentchat/tests/test_termination_condition.py::test_text_mention_termination_serializes_sources -qfailed becauseconfig.config.get("sources")wasNone..venv-agentchat/bin/python -m pytest packages/autogen-agentchat/tests/test_termination_condition.py::test_text_mention_termination_serializes_sources -qpassed..venv-agentchat/bin/python -m pytest packages/autogen-agentchat/tests/test_termination_condition.py -qpassed, 14 tests..venv-agentchat/bin/python -m ruff check packages/autogen-agentchat/src/autogen_agentchat/conditions/_terminations.py packages/autogen-agentchat/tests/test_termination_condition.pypassed..venv-agentchat/bin/python -m ruff format --check packages/autogen-agentchat/src/autogen_agentchat/conditions/_terminations.py packages/autogen-agentchat/tests/test_termination_condition.pypassed..venv-agentchat/bin/pyright --pythonpath .venv-agentchat/bin/python packages/autogen-agentchat/src/autogen_agentchat/conditions/_terminations.py packages/autogen-agentchat/tests/test_termination_condition.pypassed..venv-agentchat/bin/python -m build --wheel packages/autogen-agentchatpassed.Note: local disk was too constrained for a full workspace
uv runsync; verification used a minimal package-scoped venv withautogen-coreandautogen-agentchatinstalled editable.