Fixing configuration for MRT #5671
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -220,9 +220,9 @@ Try { | |||
| { | |||
| foreach($platformToRun in $platform.Split(",")) | |||
| { | |||
| write-host "Building MrtCore.sln for configuration $configurationToRun and platform:$platformToRun" | |||
| write-host "Building MrtCore.sln for configuration $configurationForMrtAndAnyCPU and platform:$platformToRun" | |||
There was a problem hiding this comment.
Using $configurationForMrtAndAnyCPU here results in the MRTCore solution being built only with the Release configuration, as the value appears to be hardcoded. Is building MRTCore with the Debug configuration an unsupported or intentionally disabled scenario?
There was a problem hiding this comment.
From my understanding, the entire code uses the Release configuration for MrtCore solution. This was the only place where it was different. This change is coherent with the rest of the script. I would like to confirm that with @kythant as the intended behavior.
There was a problem hiding this comment.
$configurationForMrtAndAnyCPU was used in staging the files over to the NuGet. While it's valid that we are throwing away the Debug binaries after building them, we don't really make use of the debug binaires from MRTCore. Hence, either we keep building Debug just to build Debug or we also delete the foreach loop for the configuration on line 219.
Fixes #5034
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.