Fix the resolveName function #971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -379,7 +348,7 @@ module ts { | |||
| if (ctor && ctor.locals) { | |||
| if (getSymbol(ctor.locals, name, meaning & SymbolFlags.Value)) { | |||
| // save the property node - later it will be used by 'returnResolvedSymbol' to report appropriate error | |||
There was a problem hiding this comment.
looks like this comment is out of date
|
👍 |
1 similar comment
|
👍 |
ahejlsberg
added a commit
that referenced
this pull request
Oct 27, 2014
Fix the resolveName function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
resolveNamefunction requires a replacement argument string which in most invocations is provided by callingidentifierToString. That in turn causes a lot of upfront work to be performed just in case an error needs to be reported. That doesn't make sense, particularly for such a performance critical function.This PR changes the
nameArgargument to be astring | Identifiersuch that theidentifierToStringcall can be deferred to when it is actually needed. It also gets rid of a nested function that was added to perform certain checks before returning the result (which in turn created a nested function closure on every invocation). These checks are now performed at the end of the function itself.