Correctly check types in type assertions #9170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5027,6 +5027,7 @@ namespace ts { | |||
| function getTypeFromTupleTypeNode(node: TupleTypeNode): Type { | |||
| const links = getNodeLinks(node); | |||
| if (!links.resolvedType) { | |||
| checkTupleType(node); | |||
There was a problem hiding this comment.
That's not the right fix. This function is simply for materializing the type, it isn't for the actual checking. The real problem is that checkAssertion never calls checkSourceElement on node.type. You can prove that to yourself by observing that this doesn't generate an error either:
var x = <{ a: number, a: number }>undefined; // No duplicate identifier errorSo, remove the line above and instead put a call to checkSourceElement(node.type) in checkAssertion.
DanielRosenwasser
changed the title
DanielRosenwasser
changed the title
|
Fixed. |
|
👍 |
| var y = <(a : string = "") => any>(undefined) |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9103.