Skip to content

[Transforms] Replace legacy emitter with tree transforming emitter. #9006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2016
Merged

[Transforms] Replace legacy emitter with tree transforming emitter. #9006

merged 1 commit into from
Jun 7, 2016

Conversation

rbuckton
Copy link
Contributor

@rbuckton rbuckton commented Jun 7, 2016

This change replaces the legacy emitter with the tree transforming emitter, as well as cleans up the Jakefile to remove the "runtests-file" task now that all tests are passing.

@rbuckton rbuckton added the Domain: Transforms Relates to the public transform API label Jun 7, 2016
@rbuckton
Copy link
Contributor Author

rbuckton commented Jun 7, 2016

The diff shows a large number of changes for printer.ts and emitter.ts. Really, only one change was made to printer.ts (renaming printFiles to emitFiles), and printer.ts was renamed to emitter.ts.

CC: @yuit, @sandersn, @vladima, @mhegazy

@vladima
Copy link
Contributor

vladima commented Jun 7, 2016

👍

1 similar comment
@sandersn
Copy link
Member

sandersn commented Jun 7, 2016

👍

@rbuckton rbuckton merged commit ede7692 into transforms Jun 7, 2016
@rbuckton rbuckton deleted the transforms-removeLegacyEmitter branch June 7, 2016 23:28
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Domain: Transforms Relates to the public transform API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rbuckton @vladima @sandersn @msftclas