-
Notifications
You must be signed in to change notification settings - Fork 12.9k
In tsc --b mode detect if root file of compilation is not root any more #52417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@typescript-bot perf test |
Heya @jakebailey, I've started to run the perf test suite on this PR at 8d3cb6c. You can monitor the build here. Update: The results are in! |
@jakebailey Here they are:
CompilerComparison Report - main..52417
System
Hosts
Scenarios
TSServerComparison Report - main..52417
System
Hosts
Scenarios
StartupComparison Report - main..52417
System
Hosts
Scenarios
Developer Information: |
I went and tested this PR using the linked issue's repro (https://github.com/drrnkin/typescript-composite-deleted-file), and it didn't seem to work; I removed all of the child files and reran |
Here is the result from running on the repro:
|
Ah, I didn't delete the input files, I only deleted the output files. When delete everything, I get the error. I didn't realize the issue said to literally delete everything and that an error should occur. So, I guess it does work, oops. I am however confused as to how deleting all of the output files ( |
Thats a long standing design where we dont check all output file timestamps if writing tsbuildInfo for perf reasons. If you are deleting some or all outputs, delete buildInfo and run the build has been our guidance. |
Fixes Deleted source file not detected in composite mode #51866