Skip to content

Defer computation of isDistributionDependent to avoid circularities #46474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2021
Merged

Defer computation of isDistributionDependent to avoid circularities #46474

merged 2 commits into from
Oct 22, 2021

Conversation

ahejlsberg
Copy link
Member

This is a small change to #46429 that I forgot to commit before it was merged. It defers computation of isDistributionDependent to fix a circularity that showed up in the DT types for mongoose.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Oct 22, 2021
@ahejlsberg
Copy link
Member Author

@typescript-bot run dt
@typescript-bot test this
@typescript-bot user test this
@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 22, 2021 •
edited
Loading

Heya @ahejlsberg, I've started to run the extended test suite on this PR at d6f5ace. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 22, 2021 •
edited
Loading

Heya @ahejlsberg, I've started to run the perf test suite on this PR at d6f5ace. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 22, 2021 •
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized community code test suite on this PR at d6f5ace. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 22, 2021 •
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at d6f5ace. You can monitor the build here.

@ahejlsberg
Copy link
Member Author

@typescript-bot perf test this faster

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 22, 2021 •
edited
Loading

Heya @ahejlsberg, I've started to run the perf test suite on this PR at 2b47fb7. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 22, 2021 •
edited
Loading

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at 2b47fb7. You can monitor the build here.

@typescript-bot typescript-bot mentioned this pull request Oct 22, 2021
Open
@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@andrewbranch
Copy link
Member

@typescript-bot user test this inline

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 22, 2021 •
edited
Loading

Heya @andrewbranch, I've started to run the inline community code test suite on this PR at 2b47fb7. You can monitor the build here.

Update: The results are in!

@andrewbranch
Copy link
Member

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 22, 2021 •
edited
Loading

Heya @andrewbranch, I've started to run the perf test suite on this PR at 2b47fb7. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@andrewbranch
Great news! no new errors were found between main..refs/pull/46474/merge

@typescript-bot
Copy link
Collaborator

@andrewbranch
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..46474

Metric main 46474 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 354,056k (± 0.03%) 354,053k (± 0.02%) -3k (- 0.00%) 353,911k 354,203k
Parse Time 1.95s (± 0.42%) 1.95s (± 0.66%) +0.01s (+ 0.31%) 1.93s 1.99s
Bind Time 0.84s (± 0.43%) 0.85s (± 0.80%) +0.00s (+ 0.24%) 0.84s 0.87s
Check Time 5.46s (± 0.34%) 5.47s (± 0.38%) +0.02s (+ 0.29%) 5.44s 5.53s
Emit Time 5.85s (± 0.39%) 5.86s (± 0.63%) +0.01s (+ 0.09%) 5.82s 5.98s
Total Time 14.10s (± 0.26%) 14.13s (± 0.30%) +0.03s (+ 0.18%) 14.06s 14.24s
Compiler-Unions - node (v10.16.3, x64)
Memory used 203,875k (± 0.02%) 203,829k (± 0.02%) -46k (- 0.02%) 203,742k 203,941k
Parse Time 0.78s (± 0.76%) 0.79s (± 1.05%) +0.00s (+ 0.26%) 0.77s 0.80s
Bind Time 0.52s (± 1.34%) 0.52s (± 1.24%) +0.00s (+ 0.19%) 0.50s 0.53s
Check Time 7.92s (± 0.46%) 7.89s (± 0.44%) -0.03s (- 0.37%) 7.79s 7.96s
Emit Time 2.45s (± 0.72%) 2.43s (± 0.66%) -0.02s (- 0.61%) 2.41s 2.47s
Total Time 11.68s (± 0.36%) 11.63s (± 0.39%) -0.05s (- 0.39%) 11.52s 11.73s
Monaco - node (v10.16.3, x64)
Memory used 342,045k (± 0.01%) 342,138k (± 0.03%) +94k (+ 0.03%) 341,894k 342,432k
Parse Time 1.47s (± 0.38%) 1.47s (± 0.51%) +0.00s (+ 0.14%) 1.45s 1.49s
Bind Time 0.74s (± 0.63%) 0.75s (± 0.91%) +0.01s (+ 0.81%) 0.73s 0.76s
Check Time 5.46s (± 0.66%) 5.46s (± 0.74%) -0.01s (- 0.11%) 5.36s 5.53s
Emit Time 3.17s (± 0.96%) 3.19s (± 0.79%) +0.02s (+ 0.73%) 3.13s 3.23s
Total Time 10.84s (± 0.23%) 10.87s (± 0.45%) +0.03s (+ 0.26%) 10.74s 10.99s
TFS - node (v10.16.3, x64)
Memory used 304,810k (± 0.01%) 304,820k (± 0.03%) +10k (+ 0.00%) 304,672k 305,170k
Parse Time 1.19s (± 0.50%) 1.19s (± 0.63%) -0.00s (- 0.08%) 1.18s 1.21s
Bind Time 0.71s (± 0.87%) 0.71s (± 0.47%) -0.00s (- 0.14%) 0.70s 0.72s
Check Time 4.96s (± 0.50%) 4.96s (± 0.42%) -0.01s (- 0.14%) 4.91s 5.01s
Emit Time 3.34s (± 1.44%) 3.32s (± 0.75%) -0.03s (- 0.78%) 3.26s 3.38s
Total Time 10.21s (± 0.57%) 10.18s (± 0.41%) -0.03s (- 0.32%) 10.12s 10.32s
material-ui - node (v10.16.3, x64)
Memory used 471,103k (± 0.01%) 470,435k (± 0.01%) -669k (- 0.14%) 470,316k 470,619k
Parse Time 1.77s (± 0.27%) 1.77s (± 0.40%) -0.00s (- 0.11%) 1.75s 1.79s
Bind Time 0.66s (± 0.88%) 0.66s (± 0.94%) +0.00s (+ 0.30%) 0.65s 0.67s
Check Time 14.38s (± 0.38%) 14.33s (± 0.43%) -0.05s (- 0.35%) 14.22s 14.52s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.82s (± 0.33%) 16.77s (± 0.34%) -0.05s (- 0.31%) 16.66s 16.94s
xstate - node (v10.16.3, x64)
Memory used 570,445k (± 0.01%) 569,991k (± 0.02%) -454k (- 0.08%) 569,782k 570,191k
Parse Time 2.55s (± 0.34%) 2.55s (± 0.43%) +0.00s (+ 0.04%) 2.53s 2.58s
Bind Time 1.00s (± 0.49%) 1.01s (± 0.57%) +0.01s (+ 0.60%) 1.00s 1.02s
Check Time 1.57s (± 0.52%) 1.56s (± 0.90%) -0.01s (- 0.45%) 1.54s 1.59s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.19s (± 0.24%) 5.19s (± 0.40%) -0.00s (- 0.06%) 5.15s 5.24s
Angular - node (v12.1.0, x64)
Memory used 331,869k (± 0.03%) 331,931k (± 0.03%) +62k (+ 0.02%) 331,733k 332,131k
Parse Time 1.95s (± 0.61%) 1.94s (± 0.64%) -0.01s (- 0.67%) 1.91s 1.96s
Bind Time 0.82s (± 0.68%) 0.81s (± 0.71%) -0.01s (- 0.98%) 0.80s 0.82s
Check Time 5.32s (± 0.94%) 5.30s (± 0.61%) -0.02s (- 0.47%) 5.23s 5.37s
Emit Time 6.10s (± 0.96%) 6.09s (± 0.81%) -0.02s (- 0.25%) 6.00s 6.22s
Total Time 14.19s (± 0.77%) 14.13s (± 0.51%) -0.06s (- 0.43%) 13.94s 14.33s
Compiler-Unions - node (v12.1.0, x64)
Memory used 191,289k (± 0.10%) 191,451k (± 0.05%) +162k (+ 0.08%) 191,274k 191,655k
Parse Time 0.78s (± 1.04%) 0.78s (± 0.87%) +0.00s (+ 0.13%) 0.77s 0.80s
Bind Time 0.53s (± 0.69%) 0.53s (± 0.63%) +0.00s (+ 0.76%) 0.52s 0.54s
Check Time 7.43s (± 0.88%) 7.41s (± 0.67%) -0.02s (- 0.30%) 7.29s 7.55s
Emit Time 2.46s (± 0.87%) 2.44s (± 0.61%) -0.03s (- 1.10%) 2.41s 2.48s
Total Time 11.21s (± 0.60%) 11.17s (± 0.46%) -0.04s (- 0.35%) 11.04s 11.30s
Monaco - node (v12.1.0, x64)
Memory used 325,256k (± 0.03%) 325,182k (± 0.02%) -74k (- 0.02%) 324,997k 325,331k
Parse Time 1.47s (± 0.62%) 1.46s (± 0.85%) -0.01s (- 0.34%) 1.43s 1.49s
Bind Time 0.73s (± 0.89%) 0.72s (± 0.50%) -0.00s (- 0.55%) 0.72s 0.73s
Check Time 5.34s (± 0.58%) 5.34s (± 0.38%) +0.00s (+ 0.07%) 5.30s 5.38s
Emit Time 3.19s (± 0.82%) 3.20s (± 0.55%) +0.01s (+ 0.38%) 3.15s 3.23s
Total Time 10.72s (± 0.53%) 10.73s (± 0.28%) +0.01s (+ 0.07%) 10.67s 10.79s
TFS - node (v12.1.0, x64)
Memory used 289,480k (± 0.01%) 289,476k (± 0.02%) -5k (- 0.00%) 289,396k 289,598k
Parse Time 1.22s (± 0.84%) 1.22s (± 0.79%) -0.00s (- 0.33%) 1.19s 1.23s
Bind Time 0.69s (± 0.43%) 0.69s (± 1.05%) +0.00s (+ 0.58%) 0.68s 0.71s
Check Time 4.91s (± 0.58%) 4.89s (± 0.39%) -0.02s (- 0.35%) 4.83s 4.93s
Emit Time 3.34s (± 0.58%) 3.37s (± 0.95%) +0.02s (+ 0.75%) 3.26s 3.41s
Total Time 10.15s (± 0.45%) 10.16s (± 0.53%) +0.01s (+ 0.10%) 9.97s 10.25s
material-ui - node (v12.1.0, x64)
Memory used 449,740k (± 0.06%) 449,079k (± 0.05%) -661k (- 0.15%) 448,167k 449,298k
Parse Time 1.78s (± 0.55%) 1.78s (± 0.51%) -0.00s (- 0.06%) 1.76s 1.80s
Bind Time 0.64s (± 1.01%) 0.64s (± 1.17%) -0.01s (- 0.78%) 0.62s 0.65s
Check Time 13.02s (± 0.55%) 12.98s (± 0.64%) -0.04s (- 0.32%) 12.83s 13.15s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.44s (± 0.48%) 15.40s (± 0.56%) -0.04s (- 0.29%) 15.25s 15.59s
xstate - node (v12.1.0, x64)
Memory used 536,314k (± 0.02%) 535,935k (± 0.02%) -379k (- 0.07%) 535,762k 536,164k
Parse Time 2.49s (± 0.63%) 2.48s (± 0.49%) -0.01s (- 0.28%) 2.46s 2.52s
Bind Time 1.05s (± 0.73%) 1.04s (± 0.81%) -0.00s (- 0.38%) 1.02s 1.05s
Check Time 1.52s (± 0.56%) 1.51s (± 0.66%) -0.01s (- 0.79%) 1.49s 1.53s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.12s (± 0.36%) 5.10s (± 0.33%) -0.02s (- 0.35%) 5.06s 5.14s
Angular - node (v14.15.1, x64)
Memory used 330,319k (± 0.01%) 330,339k (± 0.01%) +20k (+ 0.01%) 330,302k 330,375k
Parse Time 1.96s (± 0.59%) 1.97s (± 0.61%) +0.01s (+ 0.61%) 1.94s 1.99s
Bind Time 0.87s (± 0.89%) 0.86s (± 0.60%) -0.01s (- 0.92%) 0.85s 0.87s
Check Time 5.36s (± 0.40%) 5.38s (± 0.45%) +0.02s (+ 0.35%) 5.33s 5.44s
Emit Time 6.19s (± 0.66%) 6.19s (± 0.49%) +0.00s (+ 0.02%) 6.10s 6.23s
Total Time 14.37s (± 0.45%) 14.39s (± 0.26%) +0.03s (+ 0.17%) 14.29s 14.48s
Compiler-Unions - node (v14.15.1, x64)
Memory used 192,909k (± 0.37%) 192,893k (± 0.37%) -16k (- 0.01%) 190,005k 193,267k
Parse Time 0.81s (± 0.64%) 0.80s (± 0.61%) -0.01s (- 0.86%) 0.80s 0.82s
Bind Time 0.56s (± 0.65%) 0.56s (± 0.80%) +0.00s (+ 0.36%) 0.55s 0.57s
Check Time 7.57s (± 0.63%) 7.58s (± 0.64%) +0.00s (+ 0.03%) 7.46s 7.67s
Emit Time 2.46s (± 0.97%) 2.46s (± 1.07%) +0.01s (+ 0.33%) 2.42s 2.55s
Total Time 11.39s (± 0.35%) 11.40s (± 0.49%) +0.01s (+ 0.08%) 11.28s 11.51s
Monaco - node (v14.15.1, x64)
Memory used 324,002k (± 0.01%) 323,996k (± 0.01%) -6k (- 0.00%) 323,953k 324,032k
Parse Time 1.51s (± 0.84%) 1.50s (± 0.67%) -0.01s (- 0.46%) 1.49s 1.53s
Bind Time 0.76s (± 0.90%) 0.76s (± 0.63%) +0.00s (+ 0.13%) 0.75s 0.77s
Check Time 5.31s (± 0.35%) 5.30s (± 0.39%) -0.01s (- 0.17%) 5.24s 5.33s
Emit Time 3.23s (± 0.60%) 3.22s (± 0.91%) -0.01s (- 0.31%) 3.15s 3.28s
Total Time 10.81s (± 0.31%) 10.78s (± 0.46%) -0.02s (- 0.22%) 10.66s 10.85s
TFS - node (v14.15.1, x64)
Memory used 288,373k (± 0.00%) 288,345k (± 0.00%) -28k (- 0.01%) 288,324k 288,381k
Parse Time 1.24s (± 0.77%) 1.24s (± 0.90%) +0.00s (+ 0.08%) 1.22s 1.26s
Bind Time 0.73s (± 0.61%) 0.73s (± 1.13%) +0.00s (+ 0.41%) 0.72s 0.76s
Check Time 4.94s (± 0.54%) 4.93s (± 0.46%) -0.01s (- 0.22%) 4.88s 4.98s
Emit Time 3.52s (± 1.01%) 3.48s (± 0.33%) -0.04s (- 1.11%) 3.45s 3.50s
Total Time 10.43s (± 0.45%) 10.38s (± 0.34%) -0.05s (- 0.47%) 10.31s 10.44s
material-ui - node (v14.15.1, x64)
Memory used 448,090k (± 0.01%) 447,543k (± 0.01%) -547k (- 0.12%) 447,460k 447,578k
Parse Time 1.82s (± 0.49%) 1.83s (± 0.56%) +0.00s (+ 0.22%) 1.81s 1.85s
Bind Time 0.68s (± 1.03%) 0.68s (± 0.50%) -0.00s (- 0.59%) 0.67s 0.68s
Check Time 13.15s (± 0.56%) 13.08s (± 0.52%) -0.07s (- 0.52%) 12.96s 13.21s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.66s (± 0.46%) 15.59s (± 0.44%) -0.07s (- 0.43%) 15.48s 15.72s
xstate - node (v14.15.1, x64)
Memory used 534,234k (± 0.00%) 533,804k (± 0.00%) -430k (- 0.08%) 533,741k 533,850k
Parse Time 2.57s (± 0.43%) 2.56s (± 0.30%) -0.01s (- 0.23%) 2.54s 2.58s
Bind Time 1.15s (± 0.75%) 1.16s (± 1.20%) +0.01s (+ 0.78%) 1.13s 1.19s
Check Time 1.57s (± 0.70%) 1.56s (± 0.39%) -0.02s (- 1.14%) 1.54s 1.57s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.37s (± 0.28%) 5.35s (± 0.41%) -0.02s (- 0.32%) 5.31s 5.40s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory5 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v10.16.3, x64)
  • xstate - node (v12.1.0, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 46474 10
Baseline main 10

Developer Information:

Download Benchmark

@ahejlsberg
Copy link
Member Author

Ok, tests look good, I'm going to merge this one.

@ahejlsberg ahejlsberg merged commit 449aaa1 into main Oct 22, 2021
@ahejlsberg ahejlsberg deleted the fix44851-2 branch October 22, 2021 16:13
mprobst pushed a commit to mprobst/TypeScript that referenced this pull request Jan 10, 2022
@ahejlsberg @mprobst
Defer computation of isDistributionDependent to avoid circularities (m…
4582e49 
…icrosoft#46474)

* Defer computation of isDistributionDependent to avoid circularities

* Accept new API baselines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ahejlsberg ahejlsberg

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahejlsberg @typescript-bot @andrewbranch