Skip to content

Add an early bail when structurally comparing similar types #42726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add an early bail when structurally comparing similar types #42726

wants to merge 3 commits into from

Conversation

weswigham
Copy link
Member

@weswigham weswigham commented Feb 9, 2021 •
edited
Loading

If we are already in the middle of a more general comparison of those same types.

This is an optimization I pulled out of #31633 and tweaked a bit to bit a little more effective.

Fixes #38970

This and #42727 aren't technically mutually exclusive, but given that they target the same underlying inefficiency, I imagine we'll only take one until we have good reason to take the other.

@weswigham
When structurally comparing similar types, check if we are already in…
b3856bd 
… the middle of a more general comparison of those same types
@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Feb 9, 2021
This was referenced Feb 9, 2021
Merged
Closed
@weswigham
Copy link
Member Author

@typescript-bot perf test this
@typescript-bot run dt
@typescript-bot user test this
@typescript-bot test this
@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 9, 2021 •
edited
Loading

Heya @weswigham, I've started to run the tarball bundle task on this PR at b3856bd. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 9, 2021 •
edited
Loading

Heya @weswigham, I've started to run the perf test suite on this PR at b3856bd. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 9, 2021 •
edited
Loading

Heya @weswigham, I've started to run the extended test suite on this PR at b3856bd. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 9, 2021 •
edited
Loading

Heya @weswigham, I've started to run the parallelized community code test suite on this PR at b3856bd. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 9, 2021 •
edited
Loading

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at b3856bd. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@typescript-bot typescript-bot mentioned this pull request Feb 10, 2021
Open
@weswigham
Copy link
Member Author

@typescript-bot perf test this
@typescript-bot run dt
@typescript-bot user test this
@typescript-bot test this
@typescript-bot pack this

Had to make a small adjustment to the logic; alias symbols and type references aren't mutually exclusive anymore, so we have to check for type reference-ness first.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 10, 2021 •
edited
Loading

Heya @weswigham, I've started to run the tarball bundle task on this PR at 4a8ef89. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 10, 2021 •
edited
Loading

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 4a8ef89. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 10, 2021 •
edited
Loading

Heya @weswigham, I've started to run the extended test suite on this PR at 4a8ef89. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 10, 2021 •
edited
Loading

Heya @weswigham, I've started to run the perf test suite on this PR at 4a8ef89. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 10, 2021 •
edited
Loading

Heya @weswigham, I've started to run the parallelized community code test suite on this PR at 4a8ef89. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

@weswigham
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..42726

Metric master 42726 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 345,618k (± 0.02%) 345,790k (± 0.03%) +171k (+ 0.05%) 345,463k 345,998k
Parse Time 1.92s (± 0.40%) 1.92s (± 0.65%) +0.00s (+ 0.21%) 1.90s 1.96s
Bind Time 0.82s (± 0.60%) 0.82s (± 0.44%) 0.00s ( 0.00%) 0.82s 0.83s
Check Time 4.97s (± 0.41%) 5.00s (± 0.64%) +0.03s (+ 0.54%) 4.94s 5.08s
Emit Time 5.28s (± 0.97%) 5.26s (± 0.64%) -0.02s (- 0.36%) 5.20s 5.31s
Total Time 12.99s (± 0.38%) 13.00s (± 0.44%) +0.02s (+ 0.12%) 12.93s 13.15s
Compiler-Unions - node (v10.16.3, x64)
Memory used 214,523k (± 0.06%) 214,456k (± 0.07%) -67k (- 0.03%) 213,905k 214,596k
Parse Time 0.78s (± 0.67%) 0.78s (± 0.75%) -0.00s (- 0.26%) 0.77s 0.79s
Bind Time 0.50s (± 1.34%) 0.49s (± 1.38%) -0.00s (- 0.40%) 0.48s 0.51s
Check Time 10.65s (± 0.40%) 10.73s (± 0.45%) +0.08s (+ 0.72%) 10.63s 10.83s
Emit Time 2.35s (± 1.67%) 2.31s (± 0.85%) -0.04s (- 1.75%) 2.28s 2.38s
Total Time 14.27s (± 0.38%) 14.31s (± 0.40%) +0.03s (+ 0.24%) 14.18s 14.41s
Monaco - node (v10.16.3, x64)
Memory used 355,251k (± 0.02%) 355,511k (± 0.02%) +260k (+ 0.07%) 355,281k 355,700k
Parse Time 1.55s (± 0.58%) 1.55s (± 0.56%) -0.00s (- 0.19%) 1.53s 1.57s
Bind Time 0.72s (± 0.55%) 0.72s (± 0.50%) +0.00s (+ 0.42%) 0.72s 0.73s
Check Time 5.09s (± 0.57%) 5.15s (± 0.52%) +0.06s (+ 1.10%) 5.10s 5.23s
Emit Time 2.79s (± 0.64%) 2.80s (± 0.97%) +0.01s (+ 0.25%) 2.73s 2.85s
Total Time 10.15s (± 0.32%) 10.21s (± 0.51%) +0.06s (+ 0.62%) 10.10s 10.35s
TFS - node (v10.16.3, x64)
Memory used 308,114k (± 0.02%) 308,287k (± 0.03%) +173k (+ 0.06%) 308,102k 308,487k
Parse Time 1.20s (± 0.63%) 1.20s (± 0.48%) -0.00s (- 0.08%) 1.19s 1.21s
Bind Time 0.68s (± 0.49%) 0.68s (± 0.59%) -0.00s (- 0.15%) 0.67s 0.69s
Check Time 4.60s (± 0.57%) 4.64s (± 0.69%) +0.04s (+ 0.83%) 4.58s 4.69s
Emit Time 2.94s (± 0.83%) 2.96s (± 1.10%) +0.02s (+ 0.85%) 2.89s 3.05s
Total Time 9.42s (± 0.38%) 9.48s (± 0.54%) +0.06s (+ 0.64%) 9.36s 9.61s
material-ui - node (v10.16.3, x64)
Memory used 495,626k (± 0.02%) 0k 🟩-495,626k (-100.00%) 0k 0k
Parse Time 1.98s (± 0.39%) 0.00s 🟩-1.98s (-100.00%) 0.00s 0.00s
Bind Time 0.65s (± 0.95%) 0.00s 🟩-0.65s (-100.00%) 0.00s 0.00s
Check Time 13.95s (± 0.92%) 0.00s 🟩-13.95s (-100.00%) 0.00s 0.00s
Emit Time 0.00s (± 0.00%) 0.00s 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.59s (± 0.77%) 0.00s 🟩-16.59s (-100.00%) 0.00s 0.00s
Angular - node (v12.1.0, x64)
Memory used 323,177k (± 0.03%) 323,389k (± 0.03%) +212k (+ 0.07%) 323,189k 323,644k
Parse Time 1.90s (± 0.66%) 1.89s (± 0.75%) -0.01s (- 0.37%) 1.86s 1.91s
Bind Time 0.80s (± 0.86%) 0.80s (± 0.73%) +0.00s (+ 0.13%) 0.79s 0.81s
Check Time 4.85s (± 0.63%) 4.89s (± 0.73%) +0.04s (+ 0.76%) 4.80s 4.99s
Emit Time 5.40s (± 0.54%) 5.42s (± 0.26%) +0.03s (+ 0.48%) 5.39s 5.46s
Total Time 12.94s (± 0.47%) 13.00s (± 0.35%) +0.06s (+ 0.45%) 12.90s 13.09s
Compiler-Unions - node (v12.1.0, x64)
Memory used 199,902k (± 0.05%) 199,808k (± 0.08%) -94k (- 0.05%) 199,345k 200,033k
Parse Time 0.77s (± 0.67%) 0.76s (± 0.76%) -0.01s (- 1.04%) 0.75s 0.77s
Bind Time 0.50s (± 0.60%) 0.49s (± 0.69%) -0.01s (- 1.00%) 0.49s 0.50s
Check Time 9.72s (± 1.02%) 9.87s (± 0.66%) +0.15s (+ 1.53%) 9.70s 10.02s
Emit Time 2.34s (± 1.01%) 2.36s (± 2.00%) +0.02s (+ 0.64%) 2.27s 2.47s
Total Time 13.33s (± 0.73%) 13.48s (± 0.70%) +0.15s (+ 1.16%) 13.28s 13.74s
Monaco - node (v12.1.0, x64)
Memory used 337,476k (± 0.01%) 337,801k (± 0.02%) +325k (+ 0.10%) 337,684k 337,961k
Parse Time 1.53s (± 0.87%) 1.52s (± 0.61%) -0.01s (- 0.33%) 1.49s 1.54s
Bind Time 0.70s (± 0.63%) 0.70s (± 0.63%) +0.00s (+ 0.00%) 0.69s 0.71s
Check Time 4.91s (± 0.48%) 4.92s (± 0.63%) +0.01s (+ 0.16%) 4.87s 5.00s
Emit Time 2.86s (± 0.57%) 2.84s (± 0.63%) -0.02s (- 0.66%) 2.81s 2.89s
Total Time 10.00s (± 0.32%) 9.99s (± 0.41%) -0.01s (- 0.14%) 9.91s 10.09s
TFS - node (v12.1.0, x64)
Memory used 292,351k (± 0.01%) 292,614k (± 0.03%) +264k (+ 0.09%) 292,384k 292,838k
Parse Time 1.22s (± 0.69%) 1.22s (± 0.91%) +0.00s (+ 0.25%) 1.19s 1.24s
Bind Time 0.65s (± 0.34%) 0.65s (± 0.73%) +0.00s (+ 0.31%) 0.64s 0.66s
Check Time 4.50s (± 0.40%) 4.52s (± 0.32%) +0.02s (+ 0.47%) 4.49s 4.55s
Emit Time 2.96s (± 0.91%) 2.93s (± 0.65%) -0.03s (- 0.91%) 2.88s 2.97s
Total Time 9.33s (± 0.37%) 9.33s (± 0.28%) -0.00s (- 0.03%) 9.26s 9.37s
material-ui - node (v12.1.0, x64)
Memory used 472,776k (± 0.01%) 0k 🟩-472,776k (-100.00%) 0k 0k
Parse Time 1.99s (± 0.51%) 0.00s 🟩-1.99s (-100.00%) 0.00s 0.00s
Bind Time 0.64s (± 0.35%) 0.00s 🟩-0.64s (-100.00%) 0.00s 0.00s
Check Time 12.49s (± 0.70%) 0.00s 🟩-12.49s (-100.00%) 0.00s 0.00s
Emit Time 0.00s (± 0.00%) 0.00s 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.12s (± 0.58%) 0.00s 🟩-15.12s (-100.00%) 0.00s 0.00s
Angular - node (v14.15.1, x64)
Memory used 321,828k (± 0.01%) 322,004k (± 0.01%) +176k (+ 0.05%) 321,965k 322,036k
Parse Time 1.90s (± 0.55%) 1.90s (± 0.55%) +0.00s (+ 0.16%) 1.88s 1.93s
Bind Time 0.84s (± 0.43%) 0.85s (± 0.72%) +0.01s (+ 0.83%) 0.84s 0.87s
Check Time 4.83s (± 0.38%) 4.87s (± 0.27%) +0.03s (+ 0.66%) 4.83s 4.89s
Emit Time 5.48s (± 0.77%) 5.47s (± 0.34%) -0.00s (- 0.04%) 5.42s 5.52s
Total Time 13.05s (± 0.49%) 13.09s (± 0.20%) +0.04s (+ 0.28%) 13.02s 13.14s
Compiler-Unions - node (v14.15.1, x64)
Memory used 199,870k (± 0.38%) 201,439k (± 0.54%) +1,569k (+ 0.79%) 199,153k 202,944k
Parse Time 0.79s (± 0.62%) 0.79s (± 0.46%) -0.00s (- 0.00%) 0.79s 0.80s
Bind Time 0.53s (± 0.42%) 0.53s (± 0.56%) +0.00s (+ 0.19%) 0.53s 0.54s
Check Time 9.68s (± 0.56%) 9.87s (± 0.63%) +0.19s (+ 1.93%) 9.74s 10.00s
Emit Time 2.34s (± 1.04%) 2.36s (± 1.85%) +0.02s (+ 0.73%) 2.29s 2.46s
Total Time 13.35s (± 0.48%) 13.56s (± 0.59%) +0.21s (+ 1.57%) 13.45s 13.76s
Monaco - node (v14.15.1, x64)
Memory used 336,849k (± 0.01%) 337,130k (± 0.01%) +282k (+ 0.08%) 337,050k 337,169k
Parse Time 1.55s (± 0.58%) 1.56s (± 0.98%) +0.00s (+ 0.26%) 1.53s 1.60s
Bind Time 0.73s (± 0.71%) 0.73s (± 0.67%) +0.01s (+ 0.69%) 0.73s 0.75s
Check Time 4.85s (± 0.61%) 4.86s (± 0.44%) +0.01s (+ 0.21%) 4.82s 4.92s
Emit Time 2.91s (± 0.41%) 2.91s (± 0.37%) -0.00s (- 0.10%) 2.89s 2.94s
Total Time 10.05s (± 0.39%) 10.06s (± 0.34%) +0.01s (+ 0.14%) 9.99s 10.14s
TFS - node (v14.15.1, x64)
Memory used 291,545k (± 0.00%) 291,698k (± 0.00%) +153k (+ 0.05%) 291,672k 291,734k
Parse Time 1.24s (± 0.99%) 1.24s (± 0.87%) -0.00s (- 0.24%) 1.21s 1.26s
Bind Time 0.69s (± 0.64%) 0.69s (± 0.75%) -0.00s (- 0.14%) 0.68s 0.70s
Check Time 4.50s (± 0.62%) 4.49s (± 0.36%) -0.01s (- 0.24%) 4.44s 4.52s
Emit Time 3.03s (± 0.46%) 3.03s (± 0.81%) -0.00s (- 0.10%) 2.97s 3.09s
Total Time 9.46s (± 0.30%) 9.44s (± 0.34%) -0.02s (- 0.19%) 9.37s 9.54s
material-ui - node (v14.15.1, x64)
Memory used 471,401k (± 0.06%) 0k 🟩-471,401k (-100.00%) 0k 0k
Parse Time 2.06s (± 0.78%) 0.00s 🟩-2.06s (-100.00%) 0.00s 0.00s
Bind Time 0.70s (± 0.74%) 0.00s 🟩-0.70s (-100.00%) 0.00s 0.00s
Check Time 12.63s (± 0.83%) 0.00s 🟩-12.63s (-100.00%) 0.00s 0.00s
Emit Time 0.00s (± 0.00%) 0.00s 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.38s (± 0.75%) 0.00s 🟩-15.38s (-100.00%) 0.00s 0.00s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-198-generic
Architecturex64
Available Memory16 GB
Available Memory7 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
Benchmark Name Iterations
Current 42726 10
Baseline master 10

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 10, 2021 •
edited
Loading

Hey @weswigham, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/95553/artifacts?artifactName=tgz&fileId=627B70266F13C43643183241D694BE76F87E1DBF94487BC8B8B8A1E2E283C3D302&fileName=/typescript-4.2.0-insiders.20210210.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

@typescript-bot
Copy link
Collaborator

@weswigham
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..42726

Metric master 42726 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 345,618k (± 0.02%) 345,799k (± 0.02%) +180k (+ 0.05%) 345,597k 345,941k
Parse Time 1.92s (± 0.40%) 1.93s (± 0.78%) +0.02s (+ 0.78%) 1.89s 1.96s
Bind Time 0.82s (± 0.60%) 0.83s (± 0.97%) +0.00s (+ 0.49%) 0.82s 0.85s
Check Time 4.97s (± 0.41%) 5.00s (± 0.61%) +0.03s (+ 0.64%) 4.93s 5.05s
Emit Time 5.28s (± 0.97%) 5.28s (± 0.54%) +0.00s (+ 0.02%) 5.25s 5.37s
Total Time 12.99s (± 0.38%) 13.04s (± 0.40%) +0.05s (+ 0.42%) 12.92s 13.15s
Compiler-Unions - node (v10.16.3, x64)
Memory used 214,523k (± 0.06%) 214,461k (± 0.06%) -62k (- 0.03%) 214,008k 214,626k
Parse Time 0.78s (± 0.67%) 0.78s (± 0.44%) -0.00s (- 0.26%) 0.77s 0.78s
Bind Time 0.50s (± 1.34%) 0.51s (± 1.36%) +0.01s (+ 1.61%) 0.49s 0.52s
Check Time 10.65s (± 0.40%) 10.90s (± 0.84%) +0.25s (+ 2.38%) 10.69s 11.04s
Emit Time 2.35s (± 1.67%) 2.34s (± 1.17%) -0.01s (- 0.34%) 2.30s 2.42s
Total Time 14.27s (± 0.38%) 14.53s (± 0.69%) +0.25s (+ 1.76%) 14.32s 14.67s
Monaco - node (v10.16.3, x64)
Memory used 355,251k (± 0.02%) 355,577k (± 0.02%) +327k (+ 0.09%) 355,422k 355,688k
Parse Time 1.55s (± 0.58%) 1.56s (± 0.73%) +0.01s (+ 0.71%) 1.54s 1.59s
Bind Time 0.72s (± 0.55%) 0.73s (± 0.76%) +0.01s (+ 0.97%) 0.72s 0.74s
Check Time 5.09s (± 0.57%) 5.14s (± 0.70%) +0.05s (+ 0.94%) 5.07s 5.21s
Emit Time 2.79s (± 0.64%) 2.79s (± 0.82%) +0.00s (+ 0.14%) 2.74s 2.85s
Total Time 10.15s (± 0.32%) 10.22s (± 0.56%) +0.07s (+ 0.72%) 10.09s 10.36s
TFS - node (v10.16.3, x64)
Memory used 308,114k (± 0.02%) 308,309k (± 0.02%) +195k (+ 0.06%) 308,156k 308,408k
Parse Time 1.20s (± 0.63%) 1.21s (± 0.53%) +0.01s (+ 0.66%) 1.20s 1.23s
Bind Time 0.68s (± 0.49%) 0.68s (± 0.53%) +0.00s (+ 0.59%) 0.68s 0.69s
Check Time 4.60s (± 0.57%) 4.62s (± 0.53%) +0.02s (+ 0.35%) 4.57s 4.68s
Emit Time 2.94s (± 0.83%) 2.93s (± 1.21%) -0.00s (- 0.17%) 2.84s 3.01s
Total Time 9.42s (± 0.38%) 9.44s (± 0.57%) +0.02s (+ 0.21%) 9.30s 9.59s
material-ui - node (v10.16.3, x64)
Memory used 495,626k (± 0.02%) 495,929k (± 0.01%) +304k (+ 0.06%) 495,812k 496,037k
Parse Time 1.98s (± 0.39%) 1.97s (± 0.79%) -0.01s (- 0.35%) 1.94s 2.01s
Bind Time 0.65s (± 0.95%) 0.65s (± 0.91%) +0.00s (+ 0.46%) 0.64s 0.67s
Check Time 13.95s (± 0.92%) 14.07s (± 1.09%) +0.11s (+ 0.80%) 13.84s 14.52s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.59s (± 0.77%) 16.69s (± 0.99%) +0.11s (+ 0.64%) 16.43s 17.15s
Angular - node (v12.1.0, x64)
Memory used 323,177k (± 0.03%) 323,393k (± 0.02%) +215k (+ 0.07%) 323,177k 323,524k
Parse Time 1.90s (± 0.66%) 1.91s (± 0.68%) +0.01s (+ 0.74%) 1.87s 1.93s
Bind Time 0.80s (± 0.86%) 0.80s (± 0.91%) +0.01s (+ 0.75%) 0.79s 0.82s
Check Time 4.85s (± 0.63%) 4.90s (± 0.97%) +0.05s (+ 0.95%) 4.83s 5.07s
Emit Time 5.40s (± 0.54%) 5.45s (± 0.76%) +0.05s (+ 0.91%) 5.35s 5.51s
Total Time 12.94s (± 0.47%) 13.06s (± 0.64%) +0.12s (+ 0.89%) 12.89s 13.31s
Compiler-Unions - node (v12.1.0, x64)
Memory used 199,902k (± 0.05%) 199,777k (± 0.09%) -125k (- 0.06%) 199,214k 200,026k
Parse Time 0.77s (± 0.67%) 0.77s (± 0.64%) +0.00s (+ 0.39%) 0.77s 0.79s
Bind Time 0.50s (± 0.60%) 0.51s (± 0.74%) +0.01s (+ 1.41%) 0.50s 0.51s
Check Time 9.72s (± 1.02%) 10.01s (± 0.90%) +0.29s (+ 3.00%) 9.77s 10.18s
Emit Time 2.34s (± 1.01%) 2.36s (± 1.44%) +0.02s (+ 0.68%) 2.29s 2.41s
Total Time 13.33s (± 0.73%) 13.65s (± 0.84%) +0.32s (+ 2.39%) 13.36s 13.84s
Monaco - node (v12.1.0, x64)
Memory used 337,476k (± 0.01%) 337,767k (± 0.02%) +291k (+ 0.09%) 337,598k 337,930k
Parse Time 1.53s (± 0.87%) 1.54s (± 0.54%) +0.02s (+ 1.11%) 1.53s 1.56s
Bind Time 0.70s (± 0.63%) 0.71s (± 0.63%) +0.01s (+ 0.85%) 0.70s 0.72s
Check Time 4.91s (± 0.48%) 4.95s (± 0.29%) +0.04s (+ 0.75%) 4.93s 4.99s
Emit Time 2.86s (± 0.57%) 2.85s (± 0.77%) -0.00s (- 0.17%) 2.82s 2.90s
Total Time 10.00s (± 0.32%) 10.06s (± 0.31%) +0.06s (+ 0.61%) 10.01s 10.13s
TFS - node (v12.1.0, x64)
Memory used 292,351k (± 0.01%) 292,487k (± 0.02%) +137k (+ 0.05%) 292,389k 292,615k
Parse Time 1.22s (± 0.69%) 1.23s (± 0.73%) +0.00s (+ 0.41%) 1.20s 1.24s
Bind Time 0.65s (± 0.34%) 0.66s (± 1.26%) +0.00s (+ 0.77%) 0.64s 0.67s
Check Time 4.50s (± 0.40%) 4.51s (± 0.51%) +0.01s (+ 0.20%) 4.46s 4.57s
Emit Time 2.96s (± 0.91%) 2.93s (± 0.83%) -0.03s (- 0.88%) 2.88s 2.98s
Total Time 9.33s (± 0.37%) 9.32s (± 0.53%) -0.01s (- 0.09%) 9.23s 9.41s
material-ui - node (v12.1.0, x64)
Memory used 472,776k (± 0.01%) 472,997k (± 0.05%) +221k (+ 0.05%) 472,006k 473,338k
Parse Time 1.99s (± 0.51%) 2.00s (± 0.70%) +0.01s (+ 0.55%) 1.98s 2.04s
Bind Time 0.64s (± 0.35%) 0.65s (± 0.46%) +0.01s (+ 1.09%) 0.64s 0.65s
Check Time 12.49s (± 0.70%) 12.59s (± 0.97%) +0.09s (+ 0.75%) 12.39s 12.96s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.12s (± 0.58%) 15.23s (± 0.82%) +0.11s (+ 0.74%) 15.02s 15.61s
Angular - node (v14.15.1, x64)
Memory used 321,828k (± 0.01%) 321,995k (± 0.01%) +168k (+ 0.05%) 321,923k 322,069k
Parse Time 1.90s (± 0.55%) 1.92s (± 0.72%) +0.02s (+ 0.84%) 1.90s 1.96s
Bind Time 0.84s (± 0.43%) 0.85s (± 0.70%) +0.00s (+ 0.24%) 0.83s 0.86s
Check Time 4.83s (± 0.38%) 4.87s (± 0.43%) +0.03s (+ 0.64%) 4.81s 4.90s
Emit Time 5.48s (± 0.77%) 5.49s (± 0.73%) +0.02s (+ 0.31%) 5.41s 5.59s
Total Time 13.05s (± 0.49%) 13.12s (± 0.46%) +0.06s (+ 0.48%) 13.01s 13.24s
Compiler-Unions - node (v14.15.1, x64)
Memory used 199,870k (± 0.38%) 200,667k (± 0.56%) +797k (+ 0.40%) 199,103k 203,000k
Parse Time 0.79s (± 0.62%) 0.80s (± 0.56%) +0.00s (+ 0.50%) 0.79s 0.81s
Bind Time 0.53s (± 0.42%) 0.53s (± 0.68%) +0.00s (+ 0.56%) 0.53s 0.54s
Check Time 9.68s (± 0.56%) 10.00s (± 1.32%) +0.32s (+ 3.27%) 9.81s 10.35s
Emit Time 2.34s (± 1.04%) 2.38s (± 1.81%) +0.03s (+ 1.37%) 2.31s 2.51s
Total Time 13.35s (± 0.48%) 13.71s (± 0.99%) +0.36s (+ 2.70%) 13.46s 14.06s
Monaco - node (v14.15.1, x64)
Memory used 336,849k (± 0.01%) 337,120k (± 0.01%) +271k (+ 0.08%) 337,061k 337,182k
Parse Time 1.55s (± 0.58%) 1.56s (± 0.50%) +0.01s (+ 0.64%) 1.55s 1.58s
Bind Time 0.73s (± 0.71%) 0.73s (± 0.67%) +0.01s (+ 0.69%) 0.73s 0.75s
Check Time 4.85s (± 0.61%) 4.90s (± 0.43%) +0.04s (+ 0.91%) 4.86s 4.95s
Emit Time 2.91s (± 0.41%) 2.91s (± 1.25%) 0.00s ( 0.00%) 2.85s 3.04s
Total Time 10.05s (± 0.39%) 10.10s (± 0.42%) +0.06s (+ 0.57%) 10.02s 10.24s
TFS - node (v14.15.1, x64)
Memory used 291,545k (± 0.00%) 291,702k (± 0.00%) +157k (+ 0.05%) 291,674k 291,733k
Parse Time 1.24s (± 0.99%) 1.25s (± 1.94%) +0.01s (+ 0.72%) 1.22s 1.33s
Bind Time 0.69s (± 0.64%) 0.69s (± 0.64%) 0.00s ( 0.00%) 0.68s 0.70s
Check Time 4.50s (± 0.62%) 4.49s (± 0.40%) -0.01s (- 0.13%) 4.47s 4.56s
Emit Time 3.03s (± 0.46%) 3.05s (± 0.68%) +0.02s (+ 0.56%) 3.00s 3.09s
Total Time 9.46s (± 0.30%) 9.48s (± 0.44%) +0.02s (+ 0.21%) 9.43s 9.62s
material-ui - node (v14.15.1, x64)
Memory used 471,401k (± 0.06%) 471,658k (± 0.06%) +257k (+ 0.05%) 470,497k 471,809k
Parse Time 2.06s (± 0.78%) 2.05s (± 0.57%) -0.00s (- 0.00%) 2.02s 2.08s
Bind Time 0.70s (± 0.74%) 0.70s (± 0.57%) +0.00s (+ 0.00%) 0.69s 0.71s
Check Time 12.63s (± 0.83%) 12.64s (± 0.56%) +0.02s (+ 0.13%) 12.52s 12.86s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.38s (± 0.75%) 15.40s (± 0.47%) +0.02s (+ 0.12%) 15.28s 15.62s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-198-generic
Architecturex64
Available Memory16 GB
Available Memory7 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
Benchmark Name Iterations
Current 42726 10
Baseline master 10

@sandersn
Copy link
Member

Unfortunately, we never finished reviewing this PR. It is pretty old now, so I'm going to close it to reduce the number of open PRs.

@sandersn sandersn closed this May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn Awaiting requested review from sandersn

@ahejlsberg ahejlsberg Awaiting requested review from ahejlsberg

Assignees

@weswigham weswigham

@ahejlsberg ahejlsberg

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected very poor performance
4 participants
@weswigham @typescript-bot @sandersn @ahejlsberg