-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Fix preserveSourceNewlines sibling node comparison (fixes extra newlines in organize imports) #42630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
andrewbranch
merged 40 commits into
microsoft:master
from
andrewbranch:FixOrganizeImports
Feb 26, 2021
Merged
Fix preserveSourceNewlines sibling node comparison (fixes extra newlines in organize imports) #42630
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
cb05c28
Update package-lock.json
typescript-bot 2f4d4c1
Update package-lock.json
typescript-bot b94544a
Update package-lock.json
typescript-bot 60d63dd
Update package-lock.json
typescript-bot 3d45ac0
Update package-lock.json
typescript-bot 7dda7e3
Update package-lock.json
typescript-bot 24f0d6b
Update package-lock.json
typescript-bot a9a8cbb
Update package-lock.json
typescript-bot 9e42a69
Update package-lock.json
typescript-bot 12cc980
Update package-lock.json
typescript-bot a43ec41
Update package-lock.json
typescript-bot 3a6a36a
Update package-lock.json
typescript-bot 202873a
Update package-lock.json
typescript-bot 78ea60a
Update package-lock.json
typescript-bot 2b0578d
Update package-lock.json
typescript-bot e7c832a
Update package-lock.json
typescript-bot 62604bc
Update package-lock.json
typescript-bot 4d807de
Update package-lock.json
typescript-bot dda079d
Update package-lock.json
typescript-bot 9c121aa
Update package-lock.json
typescript-bot 8777dc7
Update package-lock.json
typescript-bot f1aa0f9
Update package-lock.json
typescript-bot e4e4cf2
Update package-lock.json
typescript-bot dd79363
Update package-lock.json
typescript-bot 2e93e31
Merge remote-tracking branch 'upstream/master'
armanio123 c709f17
More sophisticated check for source position comparability
andrewbranch 67ad6b4
Merge branch 'master' of https://github.com/armanio123/TypeScript
armanio123 5215977
Fix organize imports by looking at the nodes positions
armanio123 7cdbdb9
Merge remote-tracking branch 'upstream/master' into FixOrganizeImports
armanio123 b51345e
Rollback formatting changes
armanio123 662ee6c
Added tests, fixed organizeImports algorithm
armanio123 aaf353e
Fix autoformatting again
armanio123 c40b579
Make sibling node comparison work for all lists
andrewbranch 07930c2
Don’t run siblingNodePositionsAreComparable at all unless `preserveSo…
andrewbranch a368a48
Merge branch 'master' into FixOrganizeImports
andrewbranch de698f9
Move getNodeAtPosition back
andrewbranch 77b1902
Optimize
andrewbranch bcbec24
Use node array index check instead of tree walk
andrewbranch af14aef
Revert unneeded change
andrewbranch a0bf137
Merge branch 'master' into FixOrganizeImports
andrewbranch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.