Skip to content

Elide export assignment when it does not resolve to a value #41904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 10, 2020
Merged

Elide export assignment when it does not resolve to a value #41904

merged 3 commits into from
Dec 10, 2020
+33 −7

Conversation

andrewbranch
Copy link
Member

Fixes #40420

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Dec 9, 2020
weswigham
weswigham approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the other calls to markAliasSymbolAsReferenced need to be guarded similarly to handle other formulations of the issue?

@andrewbranch
Copy link
Member Author

Nope, all the other calls are already guarded, directly or indirectly

@andrewbranch andrewbranch merged commit 035c7ca into microsoft:master Dec 10, 2020
@andrewbranch andrewbranch deleted the bug/40420 branch December 10, 2020 18:17
@janwidmer janwidmer mentioned this pull request Dec 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

Assignees

@andrewbranch andrewbranch

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type import statement not erased when exported as default
3 participants
@andrewbranch @weswigham @typescript-bot