🤖 User test baselines have changed for refs/heads/master #37033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
weswigham
reviewed
Feb 26, 2020
| /vue-next/packages/template-explorer/src/index.ts → packages/template-explorer/dist/template-explorer.global.js... | ||
| created packages/template-explorer/dist/template-explorer.global.js in ?s | ||
| /vue-next/packages/vue/src/index.ts → packages/vue/dist/vue.esm-bundler.js... | ||
| [!] (plugin rpt2) Error: /vue-next/packages/vue/src/devCheck.ts(2,11): semantic error TS2774: This condition will always return true since the function is always defined. Did you mean to call it instead? |
There was a problem hiding this comment.
this is due to us expending the uncalled functions checks to ternaries. As far as I'm concerned, the error's not wrong (this is a defensive check).
weswigham
reviewed
Feb 26, 2020
| @@ -31,6 +90,16 @@ node_modules/enhanced-resolve/lib/CachedInputFileSystem.js(235,4): error TS2322: | |||
| node_modules/enhanced-resolve/lib/CachedInputFileSystem.js(246,4): error TS2322: Type 'null' is not assignable to type '(path: any) => any'. | |||
| node_modules/enhanced-resolve/lib/CachedInputFileSystem.js(252,24): error TS2322: Type 'null' is not assignable to type '(path: any, callback: any) => void'. | |||
| node_modules/enhanced-resolve/lib/CachedInputFileSystem.js(257,28): error TS2322: Type 'null' is not assignable to type '(path: any) => any'. | |||
| node_modules/enhanced-resolve/lib/CachedInputFileSystem.js(261,21): error TS2339: Property 'provide' does not exist on type 'Storage'. | |||
There was a problem hiding this comment.
Methinks there's a global type named Storage now which is overriding the jsdocy value-following fallback lookup.
There was a problem hiding this comment.
...no, that's not it. Something seems wrong.
typescript-bot
force-pushed
the
user-update-Microsoft-20200226-refs/heads/master
branch
from
b7b54fb to
0f2ff0b
Compare
typescript-bot
force-pushed
the
user-update-Microsoft-20200226-refs/heads/master
branch
from
0f2ff0b to
a450047
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test run was triggerd by a request on #33716
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @microsoft/typescript