Skip to content

Disallow 'declare' modifier on private named properties #36381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented Jan 23, 2020

Fixes: #36345

I also changed the error span for the other disallowed modifiers on private properties. Now the error is on the modifier instead of the name. IMO that makes more sense and aligns with the other modifier-errors on regular properties.

@DanielRosenwasser
Copy link
Member

I also changed the error span for the other disallowed modifiers on private properties. Now the error is on the modifier instead of the name

Love it, thank you!

@DanielRosenwasser DanielRosenwasser merged commit 49eb0d7 into microsoft:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disallow 'declare' modifier on private named properties
3 participants