Skip to content

Add circularity checking during deferred type argument fetching #34791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

weswigham
Copy link
Member

Fixes #34744

@weswigham weswigham merged commit 5e0fbc6 into microsoft:master Oct 30, 2019
@weswigham
Copy link
Member Author

@typescript-bot cherrypick this to release-3.7

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Oct 30, 2019
Component commits:
3904be1 Add circularity checking during deferred type argument creation
@typescript-bot
Copy link
Collaborator

Hey @weswigham, I've opened #34834 for you.

@weswigham weswigham deleted the fix-circular-deferred-type-arguments-crash branch October 30, 2019 20:50
weswigham pushed a commit that referenced this pull request Oct 30, 2019
Component commits:
3904be1 Add circularity checking during deferred type argument creation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Max Call Stack Exceeded w/ recursive circular reference via property access
3 participants