Add support for capturing cpu profiles into tsc itself #33586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
requested review from
rbuckton,
RyanCavanaugh,
sheetalkamat and
amcasey
amcasey
reviewed
Sep 24, 2019
amcasey
reviewed
Sep 24, 2019
amcasey
reviewed
Sep 24, 2019
amcasey
reviewed
Sep 24, 2019
amcasey
reviewed
Sep 24, 2019
amcasey
reviewed
Sep 24, 2019
amcasey
reviewed
Sep 24, 2019
weswigham
force-pushed
the
trace-tsc
branch
from
cfd43d4 to
5059b0d
Compare
amcasey
reviewed
Sep 25, 2019
amcasey
approved these changes
Sep 25, 2019
rbuckton
reviewed
Sep 25, 2019
|
|
||
| const commandLine = parseCommandLine(args); | ||
|
|
||
| if (commandLine.options.generateCpuProfile && sys.enableCPUProfiler) { |
There was a problem hiding this comment.
Error host doesn't support option if !sys.enableCPUProfiler ?
There was a problem hiding this comment.
Should it? It's essentially just a diagnostics flag.
AviVahl
reviewed
Sep 26, 2019
…prise people, add inspector to browser field
|
Approved by @rbuckton offline ❤️ |
|
@DanielRosenwasser should we just document this on the wiki, like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way people can pretty easily capture a trace of their compilation just by passing
--generateCpuProfile profile.cpuprofilealongside their existing compiler options. This essentially means that if you previously could send usextendedDiagnostics, this allows you to (probably) send us a cpuprofile.This is implemented using
node's builtininspectorlibrary.