Skip to content

Reverse mapped types should have inferable indexes if their source had an inferable index #33450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2019
Merged

Reverse mapped types should have inferable indexes if their source had an inferable index #33450

merged 1 commit into from
Sep 17, 2019

Conversation

weswigham
Copy link
Member

Fixes #33366

@weswigham weswigham mentioned this pull request Sep 16, 2019
Closed
@weswigham weswigham merged commit 56e2cb3 into microsoft:master Sep 17, 2019
@weswigham weswigham deleted the reverse-mapped-and-indexes branch September 17, 2019 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

@ahejlsberg ahejlsberg Awaiting requested review from ahejlsberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conditional type check on type inferred from mapped type false negative
2 participants
@weswigham @sandersn