addTypeToIntersection performance improvement #32388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@typescript-bot perf test |
|
Maybe I can run it @typescript-bot perf test |
|
Heya @orta, I've started to run the perf test suite on this PR at 8871463. You can monitor the build here. It should now contribute to this PR's status checks. Update: The results are in! |
|
@orta Here they are:Comparison Report - master..32388
System
Hosts
Scenarios
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Thanks @orta. Do I need to ping someone to review the PR? |
|
Nah, someone who knows the are of the codebase better than I will come along and review - you're in a good spot. |
weswigham
requested changes
Jul 16, 2019
| const flags = type.flags; | ||
| if (flags & TypeFlags.Intersection) { | ||
| return addTypesToIntersection(typeSet, includes, (<IntersectionType>type).types); | ||
| } | ||
| if (isEmptyAnonymousObjectType(type)) { | ||
| if (!(includes & TypeFlags.IncludesEmptyObject)) { | ||
| includes |= TypeFlags.IncludesEmptyObject; | ||
| typeSet.push(type); | ||
| typeSet.set(type.id.toString(), type); |
There was a problem hiding this comment.
We should use the getTypeId function here, since IIRC, type IDs are lazily assigned.
|
Thanks @weswigham. I've made the change. BTW, the implementation of |
🤦♂ I'm thinking of |
|
@weswigham I'm not sure I understand - what do you mean by deferred? Also, Should I revert my latest change? |
|
Yeah, just revert the original change I asked for - I was incorrect. |
|
@weswigham done. |
|
Thanks - the perf results are promising on our general suites (with results ranging from neutral to slightly positive), but I'm going to hold off merging for a second because I want to write up a microbenchmark where we can definitively see the change on (because I was once told in the past that this would be a premature optimization and that the memory pressure of swapping between an array and a map would probably make it a wash). I'll put one together shortly... |
|
Ooof, nice - at a glance (haven't done the math/many iterations/clean machine), but on my microbenchmark with a 10000 element intersection (of unique but structurally identical object types), check time is dropped in half with this change. Nice. |
|
Yep, the numbers look real good in microbenchmarks. On master, I've collected these timings from my laptop over 50 iterations per datum (where the datum is the number of intersection elements in a simple (a 10x increase in size is a 100x increase in time after a point) While with this simple fix: With 1000 or fewer elements, the timings are similar, but above that... on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29289
Changes the type of
typesargument fromType[]toMap<Type>so that membership checking can be done in O(1) instead of O(n).