Don't consider 'typeof a' as using 'a' #28528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
sheetalkamat
requested changes
Nov 15, 2018
src/compiler/checker.ts
Outdated
| @@ -55,6 +55,7 @@ namespace ts { | |||
| let cancellationToken: CancellationToken | undefined; | |||
| let requestedExternalEmitHelpers: ExternalEmitHelpers; | |||
| let externalHelpersModule: Symbol; | |||
| let isInTypeOf = false; | |||
There was a problem hiding this comment.
Do you really need this? You can get this in resolveNameHelper by doing findAncestor on location?
There was a problem hiding this comment.
There is already isInTypeQuery
sheetalkamat
approved these changes
Nov 16, 2018
sandersn
added a commit
that referenced
this pull request
Nov 26, 2018
Revert "Don't consider 'typeof a' as using 'a' (#28528)"
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where a variable that was only ever used in a
typeofexpression was still considered used.