Minor changes to reduce stack depth during emit #23882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
approved these changes
May 3, 2018
weswigham
approved these changes
May 3, 2018
src/compiler/emitter.ts
Outdated
| return pipelineEmitWithHint; | ||
|
|
||
| default: | ||
| return Debug.assertNever(phase); |
There was a problem hiding this comment.
An error message here would be helpful if this somehow ever gets triggered and reported via telementry.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subset of the changes found in #21754. This does not supersede that PR, as that PR contains additional more-aggressive changes. However, #21754 currently suffers from an as of yet undiagnosed performance regression. The minimal set of changes in this PR do not regress performance, but also do not fully resolve the issues referenced in #21754.