Add assert to make sure getOccurences at position only returns results f... #2379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for the file we request the occurences for.
| } | ||
|
|
||
| /// References and Occurrences | ||
| function getOccurrencesAtPositionCore(fileName: string, position: number): ReferenceEntry[] { |
There was a problem hiding this comment.
can we just filter instead. this is going to fail anyways. just remove the entries.
There was a problem hiding this comment.
This won't crash VS, and I rather have this fixed in the script side to prevent we do unnecessary work there.
There was a problem hiding this comment.
i meant to filter on the script side. you know the caller asked for a specific file, so just filter results that are not there.
There was a problem hiding this comment.
I think the idea is that we shouldn't be finding more results anyways. It represents a bug in our code that we should not be trying to workaround. Instead, we should track down the actual bug and fix it.
paulvanbrenk
added a commit
that referenced
this pull request
Mar 30, 2015
Add assert to make sure getOccurences at position only returns results f...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add assert to make sure getOccurences at position only returns results for the file we request the occurences for.
This should help figure out why #1153 is happening.