Skip to content

Support all path mappings that end in "*" in completions #21072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Jan 8, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jan 8, 2018

Fixes #21067

Previously we only supported the pattern "*" exactly. Now we will support patterns like "foo/*" too.

@ghost ghost requested a review from armanio123 January 8, 2018 18:37
@@ -3384,7 +3384,7 @@ ${code}
}

// @Filename is the only directive that can be used in a test that contains tsconfig.json file.
if (containTSConfigJson(files)) {
if (files.some(f => f.fileOptions.Filename === "tsconfig.json")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it consider uppercase characters as well?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch -- we were doing that elsewhere but not here.

@ghost ghost force-pushed the pathMappingCompletions branch from cc0baa0 to baaaa77 Compare January 8, 2018 19:40
@ghost ghost merged commit 97c3e9c into master Jan 8, 2018
@ghost ghost deleted the pathMappingCompletions branch January 8, 2018 20:28
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants