Support all path mappings that end in "*" in completions #21072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanio123
approved these changes
Jan 8, 2018
src/harness/fourslash.ts
Outdated
| @@ -3384,7 +3384,7 @@ ${code} | |||
| } | |||
|
|
|||
| // @Filename is the only directive that can be used in a test that contains tsconfig.json file. | |||
| if (containTSConfigJson(files)) { | |||
| if (files.some(f => f.fileOptions.Filename === "tsconfig.json")) { | |||
There was a problem hiding this comment.
Should it consider uppercase characters as well?
There was a problem hiding this comment.
Good catch -- we were doing that elsewhere but not here.
mhegazy
approved these changes
Jan 8, 2018
ghost
force-pushed
the
pathMappingCompletions
branch
from
cc0baa0 to
baaaa77
Compare
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21067
Previously we only supported the pattern
"*"exactly. Now we will support patterns like "foo/*" too.