added collision check for '_this' #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
|
LGTM |
| potentialThisCollisions.push(node); | ||
| } | ||
|
|
||
| // this function will run after checking the source file so 'CaptureThis' for all nodes |
There was a problem hiding this comment.
'CaptureThis' is correct for all nodes
|
Looks good |
vladima
added a commit
that referenced
this pull request
Jul 21, 2014
added collision check for '_this'
27 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deciding if
_thisin user code collides with_thisthat will be introduced in generated code required knowledge about arrow function that potentially reside in parts of the AST that are not yet examined. To avoid multiple tree traversals if node named_thisis found - we put it in the list of candidates and process items from this list after checking of all elements in file is finished - at this moment value ofNodeCheckFlags.CaptureThisis already set for all places that capture lexical this so collision check is relatively cheap.This fixes #64