-
Notifications
You must be signed in to change notification settings - Fork 13k
Expose compiler API needed for vue #14888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -237,4 +237,4 @@ namespace ts.server { | |
this.compilationSettings = opt; | ||
} | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1083,4 +1083,4 @@ namespace ts.server { | |
this.typeAcquisition = newTypeAcquisition; | ||
} | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
/// <reference path="../fourslash.ts"/> | ||
|
||
// @Filename: tsconfig.json | ||
//// { | ||
//// "compilerOptions": { | ||
//// "allowNonTsExtensions": true, | ||
//// "plugins": [ | ||
//// { "name": "mock-vue" } | ||
//// ] | ||
//// }, | ||
//// "files": ["a.vue"] | ||
//// } | ||
|
||
// Note: This test does *not* implement the correct vue transformation. | ||
// So it's other.data.property, not other.property or other.$data.property | ||
// @Filename: other.vue | ||
////<template> | ||
////</template> | ||
////<script> | ||
////export default { | ||
//// data: { property: "Example" } | ||
////} | ||
////</script> | ||
////<style> | ||
////</style> | ||
|
||
|
||
// @Filename: a.vue | ||
////<template> | ||
////</template> | ||
////<script> | ||
////import other from './other.vue' | ||
//// other.data.property/**/ | ||
////export default { | ||
//// data: { greeting: "Hello" } | ||
////} | ||
////</script> | ||
////<style> | ||
////</style> | ||
|
||
// LS shouldn't crash/fail if a plugin fails to init correctly | ||
goTo.marker(); | ||
verify.quickInfoIs('(property) property: string'); | ||
verify.numberOfErrorsInCurrentFile(0); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be a LanguageServiceHost optional functions. we do not want to override this for all instances of the language service.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also recommend splitting this into
createSoruceFile
andupadateSourceFile
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are global functions, so I'm not sure how to avoid overriding them for all instances of the language service. (That was probably the cause of the CI failures; bad overrides are also global.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have two options:
LanguageServiceHost
:Then in the language service, in places where we call
ts.createLanguageServiceSourceFile
orts.updateLanguageServiceSourceFile
, we can just check the host if it supports these APIs.DocumentRegistry
for the language service, and do the needed work inacquireDocument
andupdateDocument
.