Skip to content

[Discussion] Run install @types quick fix with --no-shrinkwrap #19997

Closed
@mjbvz

Description

@mjbvz

From microsoft/vscode#37217

Problem
The install quick fix currently does a normal npm install. For cases where the version of npm used to manage a project is different than the version of npm found in the environment—npm 4 and npm 5 for example—this quick fix can also unexpectedly update the npm-shrinkwrap.json.

Possible solution would be to run the @types install with --no-shrinkwrap


Moving this issue over in case any one else want to weigh in here. We run into this in the VS Code codebase itself because we don't yet support npm 5

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugA bug in TypeScriptDomain: Quick FixesEditor-provided fixes, often called code actions.Help WantedYou can do thisVS Code TrackedThere is a VS Code equivalent to this issue

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions