fix: incorrect deprecation link on Advanced Types page of old handbook #3406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanCavanaugh
requested changes
Jun 17, 2025
| @@ -3,7 +3,7 @@ title: Advanced Types | |||
| layout: docs | |||
| permalink: /docs/handbook/advanced-types.html | |||
| oneline: Advanced concepts around types in TypeScript | |||
| deprecated_by: /docs/handbook/2/types-from-types.html | |||
There was a problem hiding this comment.
The old page covers a ton of different kinds of types, but here you're linking to one very specific concept on a page that's mostly about narrowing and doesn't really serve the same purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the "Go to New Page" buttons on the Advanced Types page of the old handbook so they redirect to the same subsection of the v2 handbook