Bump to 5.5 and update compiler options #3175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
commented
Jul 8, 2024
| @@ -85,7 +85,7 @@ export const getCompilerOptionsFromParams = ( | |||
| let toSet = undefined | |||
| if (val === "true" && playgroundDefaults[key] !== true) { | |||
| toSet = true | |||
| } else if (val === "false" && playgroundDefaults[key] !== false) { | |||
| } else if (val === "false" && (playgroundDefaults[key] as any) !== false) { // TODO(jakebailey): remove as any, check undefined above | |||
There was a problem hiding this comment.
I think this may have been hiding a bug, but I don't want to change this PR to modify the behavior in this PR.
jakebailey
commented
Jul 8, 2024
packages/tsconfig-reference/copy/en/options/isolatedDeclarations.md
Outdated
Show resolved
Hide resolved
jakebailey
added
the
deploy-preview
andrewbranch
approved these changes
Jul 8, 2024
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-plant-05c166c10-3175.centralus.5.azurestaticapps.net |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.