Skip to content

Conversation

SaeWooKKang
Copy link
Contributor

I posted a question on the discord channel saying that HMR is not working, but I noticed the problem! Please let me know if you have any problems.

What this PR solves

  • Resolving Command Errors due to Package Manager Changes
  • Resolve type errors by adding factors to match capabilityCheck function parameter type

Summary

Resolving Command Errors due to Package Manager Changes

Previously, the package manager was yarn, so I think the workspace command was valid. However, it changed to pnpm and caused an error, so it was not build even though the changes existed.

스크린샷 2024-06-26 오후 7 15 34

So I deleted the workspace and added --filter.

Resolve type errors by adding factors to match capabilityCheck function parameter type

Added optional, which is the required value of the first factor of the capabilityCheck function

export interface Capabilities {
    optional: any[];
    required: any[];
}

export class Client extends EventEmitter {
    ...
    capabilityCheck(
        caps: Capabilities,
        done: doneCallback,
    ): void;
}

Steps to Reproduce

  1. run pnpm start
  2. Save your changes.
  3. Check the terminal for errors.

@jakebailey
Copy link
Member

Oops, thanks.

@jakebailey jakebailey merged commit c341935 into microsoft:v2 Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants