Skip to content

Conversation

@mhallockPcty
Copy link
Contributor

…Version enum

Fixes #394 #409 .

Changes proposed in this pull request:

  • Adds SSRS 2022 as vNext in SQLServerVersion enum to allow operations on SSRS 2022

How to test this code:

  • Try using "16" as SQL server version in various commands

Has been tested on (remove any that don't apply):

  • Powershell 3 and above
  • Windows 7 and above
  • SQL Server 2012 and above

@mhallockPcty
Copy link
Contributor Author

mhallockPcty commented Mar 28, 2024

So, Im happy to attempt to blindly fix this... it looks like your build is downloading SQL Server 2017 files, and is hard coded to use SQLServervNext in all the build steps, which is gonna change as this is updated again and again... It looks like the last time you guys did this (478edd5) this was just changing the version numbers on the downloads / temp / sql powershell module locations... I couldn't discern where you were downloading from to see if a SQLServer2022-x64-ENU.exe and SQLServer2022-x64-ENU.box existed at that location (thus the "blind attempt").

The PowerBI downloads throw me though, those don't look versioned and I have no experience with it to know if I can just update this or not. Please advise.

Also I believe 2017 is where you guys decoupled SSRS from SQL installs, so maybe that's why this hasn't been done yet? We'd need to rebuild your build pipeline to handle that split?

@mhallockPcty
Copy link
Contributor Author

@microsoft-github-policy-service agree

/// SQL Server vNext
/// </summary>
SQLServervNext = 15
SQLServervNext = 17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove SQLServervNext, we added that when SQL 2019 was announced but without a release date or branding.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed. Note the build is still failing with an error that looks intermittent on your builds? I see previous builds failing with the same issue that it looks like someone just kept hitting the retry button on until it worked... hopefully that's all my failure is?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ll investigate the build issues as well.

Copy link
Contributor

@Petebro-MSFT Petebro-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change needed

@jtarquino jtarquino merged commit ba9226a into microsoft:master Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSRS 2022 Support in "library.ps1"

3 participants