-
Notifications
You must be signed in to change notification settings - Fork 219
Addresses #394, #409, adding SSRS 2022 vNext support to the SQLServer… #424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…t to the SQLServerVersion enum
|
So, Im happy to attempt to blindly fix this... it looks like your build is downloading SQL Server 2017 files, and is hard coded to use The PowerBI downloads throw me though, those don't look versioned and I have no experience with it to know if I can just update this or not. Please advise. Also I believe 2017 is where you guys decoupled SSRS from SQL installs, so maybe that's why this hasn't been done yet? We'd need to rebuild your build pipeline to handle that split? |
|
@microsoft-github-policy-service agree |
| /// SQL Server vNext | ||
| /// </summary> | ||
| SQLServervNext = 15 | ||
| SQLServervNext = 17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove SQLServervNext, we added that when SQL 2019 was announced but without a release date or branding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed. Note the build is still failing with an error that looks intermittent on your builds? I see previous builds failing with the same issue that it looks like someone just kept hitting the retry button on until it worked... hopefully that's all my failure is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ll investigate the build issues as well.
Petebro-MSFT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change needed
…Version enum
Fixes #394 #409 .
Changes proposed in this pull request:
How to test this code:
Has been tested on (remove any that don't apply):