Skip to content

Add BaseMeshOutline inspector#10662

Merged
keveleigh merged 5 commits into
microsoft:mainfrom
Proton-V:feature/base-mesh-outline-inspector
Jul 1, 2022
Merged

Add BaseMeshOutline inspector#10662
keveleigh merged 5 commits into
microsoft:mainfrom
Proton-V:feature/base-mesh-outline-inspector

Conversation

@Proton-V

Copy link
Copy Markdown
Contributor

Changes

Overview

Added simple inspector helper for BaseMeshOutline abstract class,
used in MeshOutline && MeshOutlineHierarchy, (mb in other custom classes)

Includes

  • check current material settings
  • force update material settings to default outline mat settings
  • add new correct material

Added

  • Inspector for BaseMeshOutline abstract class

@Proton-V Proton-V requested a review from david-c-kline as a code owner June 21, 2022 03:12
@keveleigh

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@keveleigh keveleigh requested a review from Cameron-Micka June 21, 2022 22:28

@keveleigh keveleigh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@Cameron-Micka might want to take a look as well

@Cameron-Micka Cameron-Micka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing, love it! I'll open up a task to port this to MRTK3 as well.

edit: Opened: microsoft/MixedReality-GraphicsTools-Unity#33 😊

@Proton-V Proton-V requested a review from keveleigh June 28, 2022 21:49
@keveleigh keveleigh merged commit 0a4abbe into microsoft:main Jul 1, 2022
@keveleigh

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MeshOutline applied full object instead of outlining

3 participants